Issue 1287443002: SkPDF: add assert for that SkWStream behaves.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1287443002: SkPDF: add assert for that SkWStream behaves. (Closed)

Created:
5 years, 4 months ago by hal.canary

Modified:
5 years, 4 months ago

Reviewers:
tomhudson

CC:
reviews_skia.org, hcm

Base URL:
https://skia.googlesource.com/skia.git@master

Target Ref:
refs/heads/master

Project:
skia

Visibility:
Public.

More Reviews

Description

SkPDF: add assert for that SkWStream behaves. Motivation: this might catch future issues like this. BUG=skia:4181 Committed: https://skia.googlesource.com/skia/+/4f2b33159b5a5da869ed605abf1d73b5cd429934

Patch Set 1 #

Created: 5 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -2 lines)			Patch
	M	src/doc/SkDocument_PDF.cpp	View		1 chunk	+6 lines, -2 lines	0 comments	Download

Messages

Total messages: 6 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1287443002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1287443002/1

5 years, 4 months ago (2015-08-10 15:41:21 UTC) #5

commit-bot: I haz the power

5 years, 4 months ago (2015-08-10 15:49:07 UTC) #6

Message was sent while issue was closed.

Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/4f2b33159b5a5da869ed605abf1d73b5cd429934

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages