Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(318)

Issue 128743002: Adds RootWindowHost::Create() for android (Closed)

Created:
6 years, 11 months ago by sky
Modified:
6 years, 11 months ago
CC:
chromium-reviews, sadrul, ben+aura_chromium.org, kalyank
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Adds RootWindowHost::Create() for android Implementation CHECKs, so this is only needed for tests and ash, which we're not worrying about yet. BUG=none TEST=none R=ben@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=243711

Patch Set 1 #

Patch Set 2 : RootWindowHost->WindowTreeHost #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -0 lines) Patch
M ui/aura/window_tree_host.cc View 1 1 chunk +11 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
sky
6 years, 11 months ago (2014-01-08 17:33:54 UTC) #1
Ben Goodger (Google)
lgtm
6 years, 11 months ago (2014-01-08 17:43:44 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sky@chromium.org/128743002/1
6 years, 11 months ago (2014-01-08 20:56:10 UTC) #3
commit-bot: I haz the power
Failed to trigger a try job on android_dbg HTTP Error 400: Bad Request
6 years, 11 months ago (2014-01-08 22:18:07 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sky@chromium.org/128743002/270001
6 years, 11 months ago (2014-01-08 22:19:08 UTC) #5
commit-bot: I haz the power
Retried try job too often on linux_rel for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_rel&number=211645
6 years, 11 months ago (2014-01-08 23:32:43 UTC) #6
sky
6 years, 11 months ago (2014-01-09 00:34:11 UTC) #7
Message was sent while issue was closed.
Committed patchset #2 manually as r243711 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698