media/base/android/media_codec_player.h - Issue 1287423004: MediaCodecPlayer implementation (stage 5 - reconfiguration)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: media/base/android/media_codec_player.h

Issue 1287423004: MediaCodecPlayer implementation (stage 5 - reconfiguration) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@mtplayer-cleanuptest

Patch Set: Deleted better Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« media/base/android/access_unit_queue.cc ('K') | « media/base/android/media_codec_decoder_unittest.cc ('k') | media/base/android/media_codec_player.cc » ('j') | media/base/android/test_data_factory.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: media/base/android/media_codec_player.h

diff --git a/media/base/android/media_codec_player.h b/media/base/android/media_codec_player.h

index 8772ac8f26fb3bab680892ab7307852537df3493..883cf4cf966270275b72233eef75e2d62732a255 100644

--- a/media/base/android/media_codec_player.h

+++ b/media/base/android/media_codec_player.h

@@ -201,6 +201,7 @@ class MEDIA_EXPORT MediaCodecPlayer : public MediaPlayerAndroid,

// For testing only.

void SetDecodersTimeCallbackForTests(DecodersTimeCallback cb);

+ void SetAlwaysReconfigureForTests(DemuxerStream::Type type);

bool IsPrerollingForTests(DemuxerStream::Type type) const;

private:

@@ -249,7 +250,8 @@ class MEDIA_EXPORT MediaCodecPlayer : public MediaPlayerAndroid,

void RequestDemuxerData(DemuxerStream::Type stream_type);

void OnPrefetchDone();

void OnPrerollDone();

- void OnStopDone();

+ void OnDecoderDrained(DemuxerStream::Type type);

+ void OnStopDone(DemuxerStream::Type type);

void OnError();

void OnStarvation(DemuxerStream::Type stream_type);

void OnTimeIntervalUpdate(DemuxerStream::Type stream_type,