Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(302)

Unified Diff: media/base/android/test_data_factory.cc

Issue 1287423004: MediaCodecPlayer implementation (stage 5 - reconfiguration) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@mtplayer-cleanuptest
Patch Set: Fixed AdvanceAccessUnitQueue() Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « media/base/android/test_data_factory.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: media/base/android/test_data_factory.cc
diff --git a/media/base/android/test_data_factory.cc b/media/base/android/test_data_factory.cc
index cc434a82c712d450644db1fa9f4f37c5f65764f9..8a9eac4696b3fd9008623be6e2d4f5762afe8614 100644
--- a/media/base/android/test_data_factory.cc
+++ b/media/base/android/test_data_factory.cc
@@ -4,6 +4,8 @@
#include "media/base/android/test_data_factory.h"
+#include <iterator>
+
#include "base/strings/stringprintf.h"
#include "media/base/android/demuxer_stream_player_params.h"
#include "media/base/decoder_buffer.h"
@@ -60,6 +62,7 @@ TestDataFactory::TestDataFactory(const char* file_name_template,
base::TimeDelta frame_period)
: duration_(duration),
frame_period_(frame_period),
+ total_chunks_(0),
starvation_mode_(false),
eos_reached_(false) {
LoadPackets(file_name_template);
@@ -76,6 +79,16 @@ bool TestDataFactory::CreateChunk(DemuxerData* chunk, base::TimeDelta* delay) {
*delay = base::TimeDelta();
+ if (!total_chunks_ &&
+ HasReconfigForInterval(base::TimeDelta::FromMilliseconds(-1),
+ base::TimeDelta())) {
+ // Since the configs AU has to come last in the chunk the initial configs
+ // preceeding any other data has to be the only unit in the chunk.
+ AddConfiguration(chunk);
+ ++total_chunks_;
+ return true;
+ }
+
for (int i = 0; i < 4; ++i) {
chunk->access_units.push_back(AccessUnit());
AccessUnit& unit = chunk->access_units.back();
@@ -103,15 +116,38 @@ bool TestDataFactory::CreateChunk(DemuxerData* chunk, base::TimeDelta* delay) {
last_pts_ = unit.timestamp;
}
+ // Replace last access unit with |kConfigChanged| if we have a config
+ // request for the chunk's interval.
+ base::TimeDelta chunk_end_pts = regular_pts_;
+
+ // The interval is [first, last)
+ if (HasReconfigForInterval(chunk_begin_pts_, chunk_end_pts)) {
+ eos_reached_ = false;
+ regular_pts_ -= frame_period_;
+ chunk->access_units.pop_back();
+ AddConfiguration(chunk);
+ }
+ chunk_begin_pts_ = chunk_end_pts;
+
+ ++total_chunks_;
return true;
}
void TestDataFactory::SeekTo(const base::TimeDelta& seek_time) {
regular_pts_ = seek_time;
+ chunk_begin_pts_ = seek_time;
last_pts_ = base::TimeDelta();
eos_reached_ = false;
}
+void TestDataFactory::RequestInitialConfigs() {
+ reconfigs_.insert(base::TimeDelta::FromMilliseconds(-1));
+}
+
+void TestDataFactory::RequestConfigChange(base::TimeDelta config_position) {
+ reconfigs_.insert(config_position);
+}
+
void TestDataFactory::LoadPackets(const char* file_name_template) {
for (int i = 0; i < 4; ++i) {
scoped_refptr<DecoderBuffer> buffer =
@@ -121,4 +157,25 @@ void TestDataFactory::LoadPackets(const char* file_name_template) {
}
}
+bool TestDataFactory::HasReconfigForInterval(base::TimeDelta left,
+ base::TimeDelta right) const {
+ // |first| points to an element greater or equal to |left|.
+ PTSSet::const_iterator first = reconfigs_.lower_bound(left);
+
+ // |last| points to an element greater or equal to |right|.
+ PTSSet::const_iterator last = reconfigs_.lower_bound(right);
+
+ return std::distance(first, last);
+}
+
+void TestDataFactory::AddConfiguration(DemuxerData* chunk) {
+ DCHECK(chunk);
+ chunk->access_units.push_back(AccessUnit());
+ AccessUnit& unit = chunk->access_units.back();
+ unit.status = DemuxerStream::kConfigChanged;
+
+ DCHECK(chunk->demuxer_configs.empty());
+ chunk->demuxer_configs.push_back(GetConfigs());
+}
+
} // namespace media
« no previous file with comments | « media/base/android/test_data_factory.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698