media/base/android/media_codec_audio_decoder.h - Issue 1287423004: MediaCodecPlayer implementation (stage 5 - reconfiguration)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: media/base/android/media_codec_audio_decoder.h

Issue 1287423004: MediaCodecPlayer implementation (stage 5 - reconfiguration) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@mtplayer-cleanuptest

Patch Set: Avoid potential frame skipping after decoder drain with a new prerolling mode Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« media/base/android/access_unit_queue.h ('K') | « media/base/android/demuxer_stream_player_params.cc ('k') | media/base/android/media_codec_audio_decoder.cc » ('j') | media/base/android/media_codec_decoder.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: media/base/android/media_codec_audio_decoder.h

diff --git a/media/base/android/media_codec_audio_decoder.h b/media/base/android/media_codec_audio_decoder.h

index 789d68c6df550aeada6e91531a297efe5174344d..df0193fe5c09d24b56466d1c17ef81057599d51f 100644

--- a/media/base/android/media_codec_audio_decoder.h

+++ b/media/base/android/media_codec_audio_decoder.h

@@ -21,6 +21,7 @@ class MediaCodecAudioDecoder : public MediaCodecDecoder {

const scoped_refptr<base::SingleThreadTaskRunner>& media_runner,

const base::Closure& request_data_cb,

const base::Closure& starvation_cb,

+ const base::Closure& decoder_drained_cb,

const base::Closure& stop_done_cb,

const base::Closure& error_cb,

const SetTimeCallback& update_current_time_cb);

@@ -40,8 +41,7 @@ class MediaCodecAudioDecoder : public MediaCodecDecoder {

void SetBaseTimestamp(base::TimeDelta base_timestamp);

protected:

- bool IsCodecReconfigureNeeded(const DemuxerConfigs& curr,

- const DemuxerConfigs& next) const override;

+ bool IsCodecReconfigureNeeded(const DemuxerConfigs& next) const override;

ConfigStatus ConfigureInternal() override;

void OnOutputFormatChanged() override;

void Render(int buffer_index,