Scanline decoding for bmp

include/codec/SkScaledCodec.h

 /*
  * Copyright 2015 Google Inc.
  *
  * Use of this source code is governed by a BSD-style license that can be
  * found in the LICENSE file.
  */
 #ifndef SkScaledCodec_DEFINED
 #define SkScaledCodec_DEFINED
 
 #include "SkCodec.h"
@@ skipping 22 matching lines @@
         if (dstInfo.height() != srcInfo.height()) {
             return false;
         }
         // only support down sampling, dstWidth cannot be larger that srcWidth
         if(dstInfo.width() > srcInfo.width()) {
             return false;
         }
         return true;   
     }
 
+    /*
+     * Returns the first coordinate that we will keep during sampling.
+     * The output can be interpreted as an x-coordinate or a y-coordinate.

[scroggo, 2015/08/28 14:35:01]

Maybe add comments that these do not need to be (and are not) called if
sampleFactor is 1?

[msarett, 2015/08/28 15:09:18]

Done.

+     */
+    static inline int GetStartCoord(int sampleFactor);

[scroggo, 2015/08/28 14:35:01]

I believe inline functions need to be written in one place in order to inline?

[msarett, 2015/08/28 15:09:18]

You are right that this is silly.  Just typing inline in a bunch of different
places isn't going to do what I *think* we want.

I'm going to move the definitions to the header file, so that the compiler has
the option to inline if it feels like it.

+
+    /*
+     * Given a coordinate in the original image, this returns the corresponding
+     * coordinate in the scaled image.  This function is meaningless if
+     * IsCoordNecessary returns false.
+     * The output can be interpreted as an x-coordinate or a y-coordinate.
+     */
+    static inline int GetDstCoord(int srcCoord, int sampleFactor);
+
+    /*
+     * When sampling, we will discard certain y-coordinates (rows) and
+     * x-coordinates (columns).  This function returns true if we should keep the
+     * coordinate and false otherwise.
+     * The inputs may be x-coordinates or y-coordinates.
+     */
+    static bool IsCoordNecessary(int srcCoord, int sampleFactor, int scaledDim);
+
     static void ComputeSampleSize(const SkImageInfo& dstInfo, const SkImageInfo& srcInfo,
                                   int* sampleSizeX, int* sampleSizeY);
 
 protected:
     /**
      * Recommend a set of destination dimensions given a requested scale
      */
     SkISize onGetScaledDimensions(float desiredScale) const override;
 
     Result onGetPixels(const SkImageInfo&, void*, size_t, const Options&, SkPMColor*, int*)
             override;
     SkEncodedFormat onGetEncodedFormat() const override {
         return fScanlineDecoder->getEncodedFormat();
     }
 
     bool onReallyHasAlpha() const override {
         return fScanlineDecoder->reallyHasAlpha();
     }
 
 private:
 
     SkAutoTDelete<SkScanlineDecoder> fScanlineDecoder;
 
     explicit SkScaledCodec(SkScanlineDecoder*);
 
     typedef SkCodec INHERITED;
 };
 #endif // SkScaledCodec_DEFINED