Source/core/layout/LayoutObjectChildList.cpp - Issue 1287413002: Fix paint invalidation rect tracking within composited scrolling layers.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: Source/core/layout/LayoutObjectChildList.cpp

Issue 1287413002: Fix paint invalidation rect tracking within composited scrolling layers. (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

« LayoutTests/paint/invalidation/invalidate-after-composited-scroll.html ('K') | « Source/core/layout/LayoutObject.cpp ('k') | Source/core/paint/DeprecatedPaintLayer.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 /*	1 /*

2 * Copyright (C) 2009, 2010 Apple Inc. All rights reserved.	2 * Copyright (C) 2009, 2010 Apple Inc. All rights reserved.

3 * Copyright (C) Research In Motion Limited 2010. All rights reserved.	3 * Copyright (C) Research In Motion Limited 2010. All rights reserved.

4 *	4 *

5 * Redistribution and use in source and binary forms, with or without	5 * Redistribution and use in source and binary forms, with or without

6 * modification, are permitted provided that the following conditions	6 * modification, are permitted provided that the following conditions

7 * are met:	7 * are met:

8 * 1. Redistributions of source code must retain the above copyright	8 * 1. Redistributions of source code must retain the above copyright

9 * notice, this list of conditions and the following disclaimer.	9 * notice, this list of conditions and the following disclaimer.

10 * 2. Redistributions in binary form must reproduce the above copyright	10 * 2. Redistributions in binary form must reproduce the above copyright

(...skipping 173 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
184 return;	184 return;

185 if (oldChild.isBody()) {	185 if (oldChild.isBody()) {

186 oldChild.view()->setShouldDoFullPaintInvalidation();	186 oldChild.view()->setShouldDoFullPaintInvalidation();

187 return;	187 return;

188 }	188 }

189	189

190 DisableCompositingQueryAsserts disabler;	190 DisableCompositingQueryAsserts disabler;

191 // FIXME: We should not allow paint invalidation out of paint invalidation s tate. crbug.com/457415	191 // FIXME: We should not allow paint invalidation out of paint invalidation s tate. crbug.com/457415

192 DisablePaintInvalidationStateAsserts paintInvalidationAssertDisabler;	192 DisablePaintInvalidationStateAsserts paintInvalidationAssertDisabler;

193 const LayoutBoxModelObject& paintInvalidationContainer = *oldChild.container ForPaintInvalidation();	193 const LayoutBoxModelObject& paintInvalidationContainer = *oldChild.container ForPaintInvalidation();

194 oldChild.invalidatePaintUsingContainer(paintInvalidationContainer, oldChild. previousPaintInvalidationRect(), PaintInvalidationLayoutObjectRemoval);	194 oldChild.invalidatePaintUsingContainer(paintInvalidationContainer, oldChild. previousPaintInvalidationRectIncludingCompositedScrolling(paintInvalidationConta iner), PaintInvalidationLayoutObjectRemoval);

195 if (RuntimeEnabledFeatures::slimmingPaintEnabled())	195 if (RuntimeEnabledFeatures::slimmingPaintEnabled())

196 oldChild.invalidateDisplayItemClients(paintInvalidationContainer);	196 oldChild.invalidateDisplayItemClients(paintInvalidationContainer);

197 }	197 }

198	198

199 } // namespace blink	199 } // namespace blink

OLD	NEW