Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2600)

Unified Diff: Source/web/tests/WebFrameTest.cpp

Issue 1287403005: Make all methods on WebLayerTreeView optional. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | public/platform/WebLayerTreeView.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/web/tests/WebFrameTest.cpp
diff --git a/Source/web/tests/WebFrameTest.cpp b/Source/web/tests/WebFrameTest.cpp
index 495beab2bd55d0c12de54b67b0104a901bdddc2f..b42b5020512c68d5e568f4eb1b1add17fc2ae84d 100644
--- a/Source/web/tests/WebFrameTest.cpp
+++ b/Source/web/tests/WebFrameTest.cpp
@@ -4527,22 +4527,11 @@ public:
CompositedSelectionBoundsTestLayerTreeView() : m_selectionCleared(false) { }
~CompositedSelectionBoundsTestLayerTreeView() override { }
- void setRootLayer(const WebLayer&) override { }
pdr. 2015/08/19 23:46:01 Can't you just copy this code in your test? I like
- void clearRootLayer() override { }
- void setViewportSize(const WebSize& deviceViewportSize) override { }
- WebSize deviceViewportSize() const override { return WebSize(); }
- void setDeviceScaleFactor(float) override { }
- float deviceScaleFactor() const override { return 1.f; }
- void setBackgroundColor(WebColor) override { }
- void setHasTransparentBackground(bool) override { }
- void setVisible(bool) override { }
- void setPageScaleFactorAndLimits(float pageScaleFactor, float minimum, float maximum) override { }
- void startPageScaleAnimation(const WebPoint& destination, bool useAnchor, float newPageScale, double durationSec) override { }
- void finishAllRendering() override { }
void registerSelection(const WebSelection& selection) override
{
m_selection = adoptPtr(new WebSelection(selection));
}
+
void clearSelection() override
{
m_selectionCleared = true;
« no previous file with comments | « no previous file | public/platform/WebLayerTreeView.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698