test/unittests/compiler/register-allocator-unittest.cc - Issue 1287383003: Re-reland: Remove register index/code indirection

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: test/unittests/compiler/register-allocator-unittest.cc

Issue 1287383003: Re-reland: Remove register index/code indirection (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Merge with ToT Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: test/unittests/compiler/register-allocator-unittest.cc

diff --git a/test/unittests/compiler/register-allocator-unittest.cc b/test/unittests/compiler/register-allocator-unittest.cc

index 23a118b6ad157783b13d7fe85cc3fd7613adabde..0fd41d918d670b8b2f19fda0fbb9ca5497ae38c8 100644

--- a/test/unittests/compiler/register-allocator-unittest.cc

+++ b/test/unittests/compiler/register-allocator-unittest.cc

@@ -41,7 +41,8 @@ bool AllocatedOperandMatches(

const AllocatedOperand& op,

const InstructionSequenceTest::TestOperand& test_op) {

return AreOperandsOfSameType(op, test_op) &&

- (op.index() == test_op.value_ ||

+ ((op.IsRegister() ? op.GetRegister().code() : op.index()) ==

+ test_op.value_ ||

test_op.value_ == InstructionSequenceTest::kNoValue);

}