src/compiler/code-generator.cc - Issue 1287383003: Re-reland: Remove register index/code indirection

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/compiler/code-generator.cc

Issue 1287383003: Re-reland: Remove register index/code indirection (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Updated to ToT Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/compiler/code-generator.cc

diff --git a/src/compiler/code-generator.cc b/src/compiler/code-generator.cc

index 91602a02a3cde1de9f76bd20cd6ba8698c24012d..f702cce1c3c9b801849fa97e1e5d2958c47170a0 100644

--- a/src/compiler/code-generator.cc

+++ b/src/compiler/code-generator.cc

@@ -227,8 +227,7 @@ void CodeGenerator::RecordSafepoint(ReferenceMap* references,

index -= stackSlotToSpillSlotDelta;

safepoint.DefinePointerSlot(index, zone());

} else if (operand.IsRegister() && (kind & Safepoint::kWithRegisters)) {

- Register reg =

- Register::FromAllocationIndex(RegisterOperand::cast(operand).index());

+ Register reg = RegisterOperand::cast(operand).GetRegister();

safepoint.DefinePointerRegister(reg, zone());

}