Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(134)

Side by Side Diff: src/arm64/deoptimizer-arm64.cc

Issue 1287383003: Re-reland: Remove register index/code indirection (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Updated to ToT Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2013 the V8 project authors. All rights reserved. 1 // Copyright 2013 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/arm64/frames-arm64.h" 5 #include "src/arm64/frames-arm64.h"
6 #include "src/codegen.h" 6 #include "src/codegen.h"
7 #include "src/deoptimizer.h" 7 #include "src/deoptimizer.h"
8 #include "src/full-codegen/full-codegen.h" 8 #include "src/full-codegen/full-codegen.h"
9 #include "src/register-configuration.h"
9 #include "src/safepoint-table.h" 10 #include "src/safepoint-table.h"
10 11
11 12
12 namespace v8 { 13 namespace v8 {
13 namespace internal { 14 namespace internal {
14 15
15 16
16 int Deoptimizer::patch_size() { 17 int Deoptimizer::patch_size() {
17 // Size of the code used to patch lazy bailout points. 18 // Size of the code used to patch lazy bailout points.
18 // Patching is done by Deoptimizer::DeoptimizeFunction. 19 // Patching is done by Deoptimizer::DeoptimizeFunction.
(...skipping 49 matching lines...) Expand 10 before | Expand all | Expand 10 after
68 // callee saved registers in JavaScript frames, so all registers are 69 // callee saved registers in JavaScript frames, so all registers are
69 // spilled. Registers fp and sp are set to the correct values though. 70 // spilled. Registers fp and sp are set to the correct values though.
70 for (int i = 0; i < Register::NumRegisters(); i++) { 71 for (int i = 0; i < Register::NumRegisters(); i++) {
71 input_->SetRegister(i, 0); 72 input_->SetRegister(i, 0);
72 } 73 }
73 74
74 // TODO(all): Do we also need to set a value to csp? 75 // TODO(all): Do we also need to set a value to csp?
75 input_->SetRegister(jssp.code(), reinterpret_cast<intptr_t>(frame->sp())); 76 input_->SetRegister(jssp.code(), reinterpret_cast<intptr_t>(frame->sp()));
76 input_->SetRegister(fp.code(), reinterpret_cast<intptr_t>(frame->fp())); 77 input_->SetRegister(fp.code(), reinterpret_cast<intptr_t>(frame->fp()));
77 78
78 for (int i = 0; i < DoubleRegister::NumAllocatableRegisters(); i++) { 79 for (int i = 0; i < DoubleRegister::kMaxNumRegisters; i++) {
79 input_->SetDoubleRegister(i, 0.0); 80 input_->SetDoubleRegister(i, 0.0);
80 } 81 }
81 82
82 // Fill the frame content from the actual data on the frame. 83 // Fill the frame content from the actual data on the frame.
83 for (unsigned i = 0; i < input_->GetFrameSize(); i += kPointerSize) { 84 for (unsigned i = 0; i < input_->GetFrameSize(); i += kPointerSize) {
84 input_->SetFrameSlot(i, Memory::uint64_at(tos + i)); 85 input_->SetFrameSlot(i, Memory::uint64_at(tos + i));
85 } 86 }
86 } 87 }
87 88
88 89
(...skipping 26 matching lines...) Expand all
115 #define __ masm()-> 116 #define __ masm()->
116 117
117 void Deoptimizer::TableEntryGenerator::Generate() { 118 void Deoptimizer::TableEntryGenerator::Generate() {
118 GeneratePrologue(); 119 GeneratePrologue();
119 120
120 // TODO(all): This code needs to be revisited. We probably only need to save 121 // TODO(all): This code needs to be revisited. We probably only need to save
121 // caller-saved registers here. Callee-saved registers can be stored directly 122 // caller-saved registers here. Callee-saved registers can be stored directly
122 // in the input frame. 123 // in the input frame.
123 124
124 // Save all allocatable floating point registers. 125 // Save all allocatable floating point registers.
125 CPURegList saved_fp_registers(CPURegister::kFPRegister, kDRegSizeInBits, 126 CPURegList saved_fp_registers(
126 FPRegister::kAllocatableFPRegisters); 127 CPURegister::kFPRegister, kDRegSizeInBits,
128 RegisterConfiguration::ArchDefault()->allocatable_double_codes_mask());
127 __ PushCPURegList(saved_fp_registers); 129 __ PushCPURegList(saved_fp_registers);
128 130
129 // We save all the registers expcept jssp, sp and lr. 131 // We save all the registers expcept jssp, sp and lr.
130 CPURegList saved_registers(CPURegister::kRegister, kXRegSizeInBits, 0, 27); 132 CPURegList saved_registers(CPURegister::kRegister, kXRegSizeInBits, 0, 27);
131 saved_registers.Combine(fp); 133 saved_registers.Combine(fp);
132 __ PushCPURegList(saved_registers); 134 __ PushCPURegList(saved_registers);
133 135
134 __ Mov(x3, Operand(ExternalReference(Isolate::kCEntryFPAddress, isolate()))); 136 __ Mov(x3, Operand(ExternalReference(Isolate::kCEntryFPAddress, isolate())));
135 __ Str(fp, MemOperand(x3)); 137 __ Str(fp, MemOperand(x3));
136 138
(...skipping 218 matching lines...) Expand 10 before | Expand all | Expand 10 after
355 void FrameDescription::SetCallerConstantPool(unsigned offset, intptr_t value) { 357 void FrameDescription::SetCallerConstantPool(unsigned offset, intptr_t value) {
356 // No embedded constant pool support. 358 // No embedded constant pool support.
357 UNREACHABLE(); 359 UNREACHABLE();
358 } 360 }
359 361
360 362
361 #undef __ 363 #undef __
362 364
363 } // namespace internal 365 } // namespace internal
364 } // namespace v8 366 } // namespace v8
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698