Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(87)

Unified Diff: net/quic/quic_sent_packet_manager.cc

Issue 1287363002: Revert of QUIC - Call base::debug::DumpWithoutCrashing instead of crashing in (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/quic/quic_sent_packet_manager.cc
diff --git a/net/quic/quic_sent_packet_manager.cc b/net/quic/quic_sent_packet_manager.cc
index b3d94d74bed4f56a9e75fade7ea9aa9893d91cc1..566210b079f870ff0d2bff6d4344ef8bc337d269 100644
--- a/net/quic/quic_sent_packet_manager.cc
+++ b/net/quic/quic_sent_packet_manager.cc
@@ -6,7 +6,6 @@
#include <algorithm>
-#include "base/debug/dump_without_crashing.h"
#include "base/logging.h"
#include "base/stl_util.h"
#include "net/quic/congestion_control/pacing_sender.h"
@@ -655,12 +654,8 @@
MarkForRetransmission(sequence_number, TLP_RETRANSMISSION);
return true;
}
-#if defined(NDEBUG)
- base::debug::DumpWithoutCrashing();
-#else
DLOG(FATAL)
<< "No retransmittable packets, so RetransmitOldestPacket failed.";
-#endif
return false;
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698