Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(121)

Issue 1287363002: Revert of QUIC - Call base::debug::DumpWithoutCrashing instead of crashing in (Closed)

Created:
5 years, 4 months ago by ramant (doing other things)
Modified:
5 years, 4 months ago
Reviewers:
Ryan Hamilton
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of QUIC - Call base::debug::DumpWithoutCrashing instead of crashing in (patchset #1 id:1 of https://codereview.chromium.org/1281303002/ ) Reason for revert: BUG=520301 Original issue's description: > QUIC - Call base::debug::DumpWithoutCrashing instead of crashing in > QuicSentPacketManager::MaybeRetransmitTailLossProbe. > > BUG=517726 > R=rch@chromium.org > > Committed: https://crrev.com/22f7d9ae62bb4867579032e3cae46dbb5720a8ff > Cr-Commit-Position: refs/heads/master@{#342694} TBR=rch@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=517726 Committed: https://crrev.com/efd0781a90231e61889c810e1b5aff367d87094b Cr-Commit-Position: refs/heads/master@{#343227}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -5 lines) Patch
M net/quic/quic_sent_packet_manager.cc View 2 chunks +0 lines, -5 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
ramant (doing other things)
Created Revert of QUIC - Call base::debug::DumpWithoutCrashing instead of crashing in
5 years, 4 months ago (2015-08-13 17:42:52 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1287363002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1287363002/1
5 years, 4 months ago (2015-08-13 17:43:32 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 4 months ago (2015-08-13 17:44:16 UTC) #3
commit-bot: I haz the power
5 years, 4 months ago (2015-08-13 17:44:55 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/efd0781a90231e61889c810e1b5aff367d87094b
Cr-Commit-Position: refs/heads/master@{#343227}

Powered by Google App Engine
This is Rietveld 408576698