Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(148)

Issue 1287343004: Revert of Call dispatcher's releaseRegistration when done with registrations (Closed)

Created:
5 years, 4 months ago by cbiesinger
Modified:
5 years, 4 months ago
Reviewers:
jkarlin, jsbell, iclelland
CC:
blink-reviews, dglazkov+blink
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Revert of Call dispatcher's releaseRegistration when done with registrations (patchset #4 id:60001 of https://codereview.chromium.org/1279323002/ ) Reason for revert: Reverting because it causes a crash in http/tests/background_sync/oneshot.html https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux%20Leak/builds/13337 https://storage.googleapis.com/chromium-layout-test-archives/WebKit_Linux_Leak/13337/layout-test-results/results.html Original issue's description: > Call dispatcher's releaseRegistration when done with them > > With this series of patches, the BackgroundSyncManager expects clients > to call ReleaseRegistration once no longer referencing them. This CL > has Blink call releaseRegistration when the SyncRegistration and > PeriodicRegistration are deleted. > > Patch 1 [Blink]: this > Patch 2 [Browser]: https://codereview.chromium.org/1282013004 > Patch 3 [Blink cleanup]: https://codereview.chromium.org/1285653002 > > BUG=502214 > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=200504 TBR=iclelland@chromium.org,jsbell@chromium.org,jkarlin@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=502214 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=200544

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -19 lines) Patch
M Source/modules/background_sync/PeriodicSyncRegistration.cpp View 1 chunk +0 lines, -3 lines 0 comments Download
M Source/modules/background_sync/SyncRegistration.cpp View 1 chunk +0 lines, -3 lines 0 comments Download
M public/platform/modules/background_sync/WebSyncProvider.h View 1 chunk +0 lines, -13 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
cbiesinger
Created Revert of Call dispatcher's releaseRegistration when done with registrations
5 years, 4 months ago (2015-08-14 16:05:36 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1287343004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1287343004/1
5 years, 4 months ago (2015-08-14 16:05:41 UTC) #2
commit-bot: I haz the power
5 years, 4 months ago (2015-08-14 16:06:08 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=200544

Powered by Google App Engine
This is Rietveld 408576698