Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(581)

Issue 1287333002: Revert of [scheduler]: Fix a bug with non-nestable tasks. (Closed)

Created:
5 years, 4 months ago by rmcilroy
Modified:
5 years, 4 months ago
Reviewers:
Sami
CC:
chromium-reviews, scheduler-bugs_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of [scheduler]: Fix a bug with non-nestable tasks. (patchset #2 id:20001 of https://codereview.chromium.org/1287003003/ ) Reason for revert: Causing crashes on Mac. BUG=520524 Original issue's description: > [scheduler]: Fix a bug with non-nestable tasks. > > Avoids a DCHECK in TaskQueueImpl::Task::enqueue_order() caused by > TaskIsOlderThanQueuedTasks being called on an empty task if the previous > task was a non-nestable task while the scheduler is running on a nested > message loop. > > Committed: https://crrev.com/c0d31ab28e21c048f40584ace3b0a8aca5723c17 > Cr-Commit-Position: refs/heads/master@{#343026} TBR=skyostil@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Committed: https://crrev.com/8a68a446db4553aad0f31e68baef0ae638b92f7f Cr-Commit-Position: refs/heads/master@{#343194}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -54 lines) Patch
M components/scheduler/child/task_queue_manager.cc View 2 chunks +4 lines, -7 lines 0 comments Download
M components/scheduler/child/task_queue_manager_unittest.cc View 1 chunk +0 lines, -47 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
rmcilroy
Created Revert of [scheduler]: Fix a bug with non-nestable tasks.
5 years, 4 months ago (2015-08-13 14:54:52 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1287333002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1287333002/1
5 years, 4 months ago (2015-08-13 14:54:59 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 4 months ago (2015-08-13 14:55:22 UTC) #3
commit-bot: I haz the power
5 years, 4 months ago (2015-08-13 14:56:00 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/8a68a446db4553aad0f31e68baef0ae638b92f7f
Cr-Commit-Position: refs/heads/master@{#343194}

Powered by Google App Engine
This is Rietveld 408576698