Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(377)

Issue 1287263004: Move spell checker in core/editing/ related files into core/editing/spellcheck/ (Closed)

Created:
5 years, 4 months ago by yosin_UTC9
Modified:
5 years, 4 months ago
Reviewers:
tkent
CC:
blink-reviews, blink-reviews-html_chromium.org, sof, eae+blinkwatch, blink-reviews-dom_chromium.org, dglazkov+blink, groby+blinkspell_chromium.org, rwlbuis, yoichio
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Move spell checker in core/editing/ related files into core/editing/spellcheck/ This patch moves spell checker related files into "core/editing/spellcheck/" directory to reduce number of files immediately under "core/editing/" for ease of working these files as same as issue 448772, which moves iterator related files into "core/editing/iterators/". Moved files: - SpellCheckRequest.{cpp,h} - SpellChecker.{cpp,h} - TextCheckingHelper.{cpp,h} BUG=509527 TEST=n/a; no behavior changes Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=200625

Patch Set 1 : 2015-08-17T10:33:57 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -2202 lines) Patch
M Source/core/core.gypi View 3 chunks +6 lines, -6 lines 0 comments Download
M Source/core/dom/Document.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/editing/CompositeEditCommand.cpp View 2 chunks +1 line, -1 line 0 comments Download
M Source/core/editing/Editor.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/editing/EditorCommand.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/editing/FrameSelection.cpp View 1 chunk +1 line, -1 line 0 comments Download
D Source/core/editing/SpellCheckRequester.h View 1 chunk +0 lines, -139 lines 0 comments Download
D Source/core/editing/SpellCheckRequester.cpp View 1 chunk +0 lines, -287 lines 0 comments Download
D Source/core/editing/SpellChecker.h View 1 chunk +0 lines, -117 lines 0 comments Download
D Source/core/editing/SpellChecker.cpp View 1 chunk +0 lines, -946 lines 0 comments Download
D Source/core/editing/TextCheckingHelper.h View 1 chunk +0 lines, -108 lines 0 comments Download
D Source/core/editing/TextCheckingHelper.cpp View 1 chunk +0 lines, -580 lines 0 comments Download
M Source/core/editing/TypingCommand.cpp View 1 chunk +1 line, -1 line 0 comments Download
A + Source/core/editing/spellcheck/SpellCheckRequester.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + Source/core/editing/spellcheck/SpellCheckRequester.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
A + Source/core/editing/spellcheck/SpellChecker.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + Source/core/editing/spellcheck/SpellChecker.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
A + Source/core/editing/spellcheck/TextCheckingHelper.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + Source/core/editing/spellcheck/TextCheckingHelper.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/frame/LocalFrame.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/HTMLInputElement.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/HTMLTextAreaElement.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/HTMLTextFormControlElementTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/testing/Internals.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/web/ContextMenuClientImpl.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/web/SpellCheckerClientImpl.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/web/WebLocalFrameImpl.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/web/tests/WebFrameTest.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (2 generated)
yosin_UTC9
PTAL
5 years, 4 months ago (2015-08-17 02:01:01 UTC) #2
tkent
lgtm
5 years, 4 months ago (2015-08-17 02:15:50 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1287263004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1287263004/1
5 years, 4 months ago (2015-08-17 02:18:46 UTC) #5
commit-bot: I haz the power
5 years, 4 months ago (2015-08-17 03:22:37 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=200625

Powered by Google App Engine
This is Rietveld 408576698