Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(580)

Issue 1287253005: Test both viewports' scrollability during fullscreen-video (Closed)

Created:
5 years, 4 months ago by Hugo Holgersson
Modified:
5 years, 4 months ago
Reviewers:
bokan
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Test both viewports' scrollability during fullscreen-video Background: To disable scrolling (and pinch-zoom) during <video>- fullscreen ScrollingCoordinator makes both viewports unscrollable in updateAfterCompositingChangeIfNeeded(). Problem: Currently only the outer viewport's scrollability- setting is tested during fullscreen-video. Solution: Extend test case to also verify the inner viewport. BUG=448738 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=201007

Patch Set 1 #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -9 lines) Patch
M Source/web/tests/WebFrameTest.cpp View 1 chunk +14 lines, -9 lines 3 comments Download

Messages

Total messages: 8 (2 generated)
Hugo Holgersson
@bokan PTAL.
5 years, 4 months ago (2015-08-14 16:59:17 UTC) #2
bokan
lgtm! https://codereview.chromium.org/1287253005/diff/1/Source/web/tests/WebFrameTest.cpp File Source/web/tests/WebFrameTest.cpp (right): https://codereview.chromium.org/1287253005/diff/1/Source/web/tests/WebFrameTest.cpp#newcode6529 Source/web/tests/WebFrameTest.cpp:6529: WebLayer* layoutViewportScrollLayer = webViewImpl->compositor()->scrollLayer()->platformLayer(); It's probably slightly more ...
5 years, 4 months ago (2015-08-18 12:35:49 UTC) #3
Hugo Holgersson
Thanks! https://codereview.chromium.org/1287253005/diff/1/Source/web/tests/WebFrameTest.cpp File Source/web/tests/WebFrameTest.cpp (right): https://codereview.chromium.org/1287253005/diff/1/Source/web/tests/WebFrameTest.cpp#newcode6529 Source/web/tests/WebFrameTest.cpp:6529: WebLayer* layoutViewportScrollLayer = webViewImpl->compositor()->scrollLayer()->platformLayer(); On 2015/08/18 12:35:49, bokan ...
5 years, 4 months ago (2015-08-20 21:12:56 UTC) #4
Hugo Holgersson
https://codereview.chromium.org/1287253005/diff/1/Source/web/tests/WebFrameTest.cpp File Source/web/tests/WebFrameTest.cpp (right): https://codereview.chromium.org/1287253005/diff/1/Source/web/tests/WebFrameTest.cpp#newcode6529 Source/web/tests/WebFrameTest.cpp:6529: WebLayer* layoutViewportScrollLayer = webViewImpl->compositor()->scrollLayer()->platformLayer(); On 2015/08/20 21:12:56, Hugo Holgersson ...
5 years, 4 months ago (2015-08-21 17:28:48 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1287253005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1287253005/1
5 years, 4 months ago (2015-08-21 17:29:33 UTC) #7
commit-bot: I haz the power
5 years, 4 months ago (2015-08-21 19:56:43 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=201007

Powered by Google App Engine
This is Rietveld 408576698