pkg/compiler/lib/src/tree_ir/optimization/logical_rewriter.dart - Issue 1287253002: dart2js cps: Compile some loops as 'for' loops.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/compiler/lib/src/tree_ir/optimization/logical_rewriter.dart

Issue 1287253002: dart2js cps: Compile some loops as 'for' loops. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master

Patch Set: Update test expectations Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: pkg/compiler/lib/src/tree_ir/optimization/logical_rewriter.dart

diff --git a/pkg/compiler/lib/src/tree_ir/optimization/logical_rewriter.dart b/pkg/compiler/lib/src/tree_ir/optimization/logical_rewriter.dart

index 0bb70ed14ee9d9695136c159c23ebb4e491f5126..3c6a173ea04a7c76647c6ee2d967a57645bf0914 100644

--- a/pkg/compiler/lib/src/tree_ir/optimization/logical_rewriter.dart

+++ b/pkg/compiler/lib/src/tree_ir/optimization/logical_rewriter.dart

@@ -190,7 +190,7 @@ class LogicalRewriter extends RecursiveTransformer

return node;

}

- Statement visitWhileCondition(WhileCondition node) {

+ Statement visitFor(For node) {

fallthrough.push(node);

node.condition = makeCondition(node.condition, true, liftNots: false);

node.body = visitStatement(node.body);