Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(139)

Unified Diff: fpdfsdk/src/fpdfview.cpp

Issue 1287193005: Use override in more classes in fpdfsdk/ (Closed) Base URL: https://pdfium.googlesource.com/pdfium@master
Patch Set: nits, rebase Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « fpdfsdk/src/fpdfsave.cpp ('k') | fpdfsdk/src/fsdk_mgr.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: fpdfsdk/src/fpdfview.cpp
diff --git a/fpdfsdk/src/fpdfview.cpp b/fpdfsdk/src/fpdfview.cpp
index 2700aebddc079eae29941e59776b63a949b37d66..a1d5689c7942158cac57c0ae6da7b4a6b3ee99c3 100644
--- a/fpdfsdk/src/fpdfview.cpp
+++ b/fpdfsdk/src/fpdfview.cpp
@@ -71,9 +71,10 @@ CCodec_ModuleMgr* g_pCodecModule = nullptr;
class CFontMapper : public IPDF_FontMapper {
public:
CFontMapper();
- virtual ~CFontMapper();
+ ~CFontMapper() override;
- virtual FT_Face FindSubstFont(
+ // IPDF_FontMapper
+ FT_Face FindSubstFont(
CPDF_Document* pDoc, // [IN] The PDF document
const CFX_ByteString& face_name, // [IN] Original name
FX_BOOL bTrueType, // [IN] TrueType or Type1
@@ -82,7 +83,7 @@ class CFontMapper : public IPDF_FontMapper {
int CharsetCP, // [IN] code page for charset (see Win32 GetACP())
FX_BOOL bVertical,
CPDF_SubstFont* pSubstFont // [OUT] Subst font data
- );
+ ) override;
FT_Face m_SysFace;
};
@@ -204,6 +205,8 @@ class CMemFile final : public IFX_FileRead {
}
private:
+ ~CMemFile() {}
+
uint8_t* m_pBuf;
FX_FILESIZE m_size;
};
« no previous file with comments | « fpdfsdk/src/fpdfsave.cpp ('k') | fpdfsdk/src/fsdk_mgr.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698