Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Unified Diff: fpdfsdk/include/javascript/global.h

Issue 1287193005: Use override in more classes in fpdfsdk/ (Closed) Base URL: https://pdfium.googlesource.com/pdfium@master
Patch Set: nits, rebase Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « fpdfsdk/include/javascript/event.h ('k') | fpdfsdk/include/javascript/report.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: fpdfsdk/include/javascript/global.h
diff --git a/fpdfsdk/include/javascript/global.h b/fpdfsdk/include/javascript/global.h
index 303ac76a3e01b6072139b605715dbca10e418f83..369956749b8e6f341e4d8a2cc09f17712de62d17 100644
--- a/fpdfsdk/include/javascript/global.h
+++ b/fpdfsdk/include/javascript/global.h
@@ -36,7 +36,7 @@ struct js_global_data {
class global_alternate : public CJS_EmbedObj {
public:
global_alternate(CJS_Object* pJSObject);
- virtual ~global_alternate();
+ ~global_alternate() override;
public:
FX_BOOL setPersistent(IFXJS_Context* cc,
@@ -81,10 +81,11 @@ class global_alternate : public CJS_EmbedObj {
class CJS_Global : public CJS_Object {
public:
- CJS_Global(JSFXObject pObject) : CJS_Object(pObject){};
- virtual ~CJS_Global(void){};
+ explicit CJS_Global(JSFXObject pObject) : CJS_Object(pObject) {}
+ ~CJS_Global() override {}
- virtual FX_BOOL InitInstance(IFXJS_Context* cc);
+ // CJS_Object
+ FX_BOOL InitInstance(IFXJS_Context* cc) override;
DECLARE_SPECIAL_JS_CLASS(CJS_Global);
« no previous file with comments | « fpdfsdk/include/javascript/event.h ('k') | fpdfsdk/include/javascript/report.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698