Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(787)

Unified Diff: fpdfsdk/include/javascript/app.h

Issue 1287193005: Use override in more classes in fpdfsdk/ (Closed) Base URL: https://pdfium.googlesource.com/pdfium@master
Patch Set: nits, rebase Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « fpdfsdk/include/javascript/PublicMethods.h ('k') | fpdfsdk/include/javascript/color.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: fpdfsdk/include/javascript/app.h
diff --git a/fpdfsdk/include/javascript/app.h b/fpdfsdk/include/javascript/app.h
index b13121323b7dfe0b6ee0a7588a227dafc4d00a11..995c2605dfcd9fb0194ecfc130dfa1e363256ebc 100644
--- a/fpdfsdk/include/javascript/app.h
+++ b/fpdfsdk/include/javascript/app.h
@@ -18,7 +18,7 @@ class CJS_Timer;
class TimerObj : public CJS_EmbedObj {
public:
TimerObj(CJS_Object* pJSObject);
- virtual ~TimerObj();
+ ~TimerObj() override;
public:
void SetTimer(CJS_Timer* pTimer);
@@ -31,7 +31,7 @@ class TimerObj : public CJS_EmbedObj {
class CJS_TimerObj : public CJS_Object {
public:
CJS_TimerObj(JSFXObject pObject) : CJS_Object(pObject) {}
- virtual ~CJS_TimerObj() {}
+ ~CJS_TimerObj() override {}
DECLARE_JS_CLASS(CJS_TimerObj);
};
@@ -39,7 +39,7 @@ class CJS_TimerObj : public CJS_Object {
class app : public CJS_EmbedObj {
public:
app(CJS_Object* pJSObject);
- virtual ~app();
+ ~app() override;
public:
FX_BOOL activeDocs(IFXJS_Context* cc,
@@ -160,24 +160,22 @@ class app : public CJS_EmbedObj {
CJS_Value& vRet,
CFX_WideString& sError);
- private:
- void TimerProc(CJS_Timer* pTimer);
- void RunJsScript(CJS_Runtime* pRuntime, const CFX_WideString& wsScript);
-
- public:
static CFX_WideString SysPathToPDFPath(const CFX_WideString& sOldPath);
private:
+ // CJS_EmbedObj
+ void TimerProc(CJS_Timer* pTimer) override;
+ void RunJsScript(CJS_Runtime* pRuntime, const CFX_WideString& wsScript);
+
bool m_bCalculate;
bool m_bRuntimeHighLight;
-
CFX_ArrayTemplate<CJS_Timer*> m_aTimer;
};
class CJS_App : public CJS_Object {
public:
- CJS_App(JSFXObject pObject) : CJS_Object(pObject){};
- virtual ~CJS_App(void){};
+ explicit CJS_App(JSFXObject pObject) : CJS_Object(pObject) {}
+ ~CJS_App() override {}
DECLARE_JS_CLASS(CJS_App);
« no previous file with comments | « fpdfsdk/include/javascript/PublicMethods.h ('k') | fpdfsdk/include/javascript/color.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698