Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(142)

Unified Diff: fpdfsdk/include/javascript/Document.h

Issue 1287193005: Use override in more classes in fpdfsdk/ (Closed) Base URL: https://pdfium.googlesource.com/pdfium@master
Patch Set: nits, rebase Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « fpdfsdk/include/javascript/Consts.h ('k') | fpdfsdk/include/javascript/Field.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: fpdfsdk/include/javascript/Document.h
diff --git a/fpdfsdk/include/javascript/Document.h b/fpdfsdk/include/javascript/Document.h
index 7d0e05fc4376ea8022f8ea54dd5f783dfd180e7a..e139557f1b62b0ccd978926c6e699703eedff8cc 100644
--- a/fpdfsdk/include/javascript/Document.h
+++ b/fpdfsdk/include/javascript/Document.h
@@ -12,7 +12,7 @@
class PrintParamsObj : public CJS_EmbedObj {
public:
PrintParamsObj(CJS_Object* pJSObject);
- virtual ~PrintParamsObj() {}
+ ~PrintParamsObj() override {}
public:
FX_BOOL bUI;
@@ -28,7 +28,7 @@ class PrintParamsObj : public CJS_EmbedObj {
class CJS_PrintParamsObj : public CJS_Object {
public:
CJS_PrintParamsObj(JSFXObject pObject) : CJS_Object(pObject) {}
- virtual ~CJS_PrintParamsObj() {}
+ ~CJS_PrintParamsObj() override {}
DECLARE_JS_CLASS(CJS_PrintParamsObj);
};
@@ -69,7 +69,7 @@ struct CJS_AnnotObj;
class Document : public CJS_EmbedObj {
public:
Document(CJS_Object* pJSObject);
- virtual ~Document();
+ ~Document() override;
public:
FX_BOOL ADBE(IFXJS_Context* cc, CJS_PropValue& vp, CFX_WideString& sError);
@@ -322,10 +322,11 @@ class Document : public CJS_EmbedObj {
class CJS_Document : public CJS_Object {
public:
- CJS_Document(JSFXObject pObject) : CJS_Object(pObject){};
- virtual ~CJS_Document(){};
+ explicit CJS_Document(JSFXObject pObject) : CJS_Object(pObject) {}
+ ~CJS_Document() override {}
- virtual FX_BOOL InitInstance(IFXJS_Context* cc);
+ // CJS_Object
+ FX_BOOL InitInstance(IFXJS_Context* cc) override;
DECLARE_JS_CLASS(CJS_Document);
« no previous file with comments | « fpdfsdk/include/javascript/Consts.h ('k') | fpdfsdk/include/javascript/Field.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698