Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1113)

Side by Side Diff: fpdfsdk/include/javascript/JS_Runtime.h

Issue 1287193005: Use override in more classes in fpdfsdk/ (Closed) Base URL: https://pdfium.googlesource.com/pdfium@master
Patch Set: nits, rebase Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « fpdfsdk/include/javascript/JS_Object.h ('k') | fpdfsdk/include/javascript/PublicMethods.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 PDFium Authors. All rights reserved. 1 // Copyright 2014 PDFium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com 5 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com
6 6
7 #ifndef FPDFSDK_INCLUDE_JAVASCRIPT_JS_RUNTIME_H_ 7 #ifndef FPDFSDK_INCLUDE_JAVASCRIPT_JS_RUNTIME_H_
8 #define FPDFSDK_INCLUDE_JAVASCRIPT_JS_RUNTIME_H_ 8 #define FPDFSDK_INCLUDE_JAVASCRIPT_JS_RUNTIME_H_
9 9
10 #include "../../../third_party/base/nonstd_unique_ptr.h" 10 #include "../../../third_party/base/nonstd_unique_ptr.h"
(...skipping 13 matching lines...) Expand all
24 class CJS_FieldEvent { 24 class CJS_FieldEvent {
25 public: 25 public:
26 CFX_WideString sTargetName; 26 CFX_WideString sTargetName;
27 JS_EVENT_T eEventType; 27 JS_EVENT_T eEventType;
28 CJS_FieldEvent* pNext; 28 CJS_FieldEvent* pNext;
29 }; 29 };
30 30
31 class CJS_Runtime : public IFXJS_Runtime { 31 class CJS_Runtime : public IFXJS_Runtime {
32 public: 32 public:
33 CJS_Runtime(CPDFDoc_Environment* pApp); 33 CJS_Runtime(CPDFDoc_Environment* pApp);
34 virtual ~CJS_Runtime(); 34 ~CJS_Runtime() override;
35 35
36 virtual IFXJS_Context* NewContext(); 36 // IFXJS_Runtime
37 virtual void ReleaseContext(IFXJS_Context* pContext); 37 IFXJS_Context* NewContext() override;
38 virtual IFXJS_Context* GetCurrentContext(); 38 void ReleaseContext(IFXJS_Context* pContext) override;
39 39 IFXJS_Context* GetCurrentContext() override;
40 virtual void SetReaderDocument(CPDFSDK_Document* pReaderDoc); 40 void SetReaderDocument(CPDFSDK_Document* pReaderDoc) override;
41 virtual CPDFSDK_Document* GetReaderDocument() { return m_pDocument; } 41 CPDFSDK_Document* GetReaderDocument() override { return m_pDocument; }
42 42
43 CPDFDoc_Environment* GetReaderApp() { return m_pApp; } 43 CPDFDoc_Environment* GetReaderApp() { return m_pApp; }
44 44
45 FX_BOOL InitJSObjects(); 45 FX_BOOL InitJSObjects();
46 46
47 FX_BOOL AddEventToLoop(const CFX_WideString& sTargetName, 47 FX_BOOL AddEventToLoop(const CFX_WideString& sTargetName,
48 JS_EVENT_T eEventType); 48 JS_EVENT_T eEventType);
49 void RemoveEventInLoop(const CFX_WideString& sTargetName, 49 void RemoveEventInLoop(const CFX_WideString& sTargetName,
50 JS_EVENT_T eEventType); 50 JS_EVENT_T eEventType);
51 void RemoveEventsInLoop(CJS_FieldEvent* pStart); 51 void RemoveEventsInLoop(CJS_FieldEvent* pStart);
(...skipping 15 matching lines...) Expand all
67 FX_BOOL m_bBlocking; 67 FX_BOOL m_bBlocking;
68 CJS_FieldEvent* m_pFieldEventPath; 68 CJS_FieldEvent* m_pFieldEventPath;
69 69
70 v8::Isolate* m_isolate; 70 v8::Isolate* m_isolate;
71 bool m_isolateManaged; 71 bool m_isolateManaged;
72 nonstd::unique_ptr<CJS_ArrayBufferAllocator> m_pArrayBufferAllocator; 72 nonstd::unique_ptr<CJS_ArrayBufferAllocator> m_pArrayBufferAllocator;
73 v8::Global<v8::Context> m_context; 73 v8::Global<v8::Context> m_context;
74 }; 74 };
75 75
76 #endif // FPDFSDK_INCLUDE_JAVASCRIPT_JS_RUNTIME_H_ 76 #endif // FPDFSDK_INCLUDE_JAVASCRIPT_JS_RUNTIME_H_
OLDNEW
« no previous file with comments | « fpdfsdk/include/javascript/JS_Object.h ('k') | fpdfsdk/include/javascript/PublicMethods.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698