Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(24)

Issue 1287133002: Add apktool and apktool.jar to install-build-deps-android.sh (Closed)

Created:
5 years, 4 months ago by navabi1
Modified:
5 years, 4 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add apktool and apktool.jar to install-build-deps-android.sh BUG=452927 TBR=cjhopman@chromium.org Committed: https://crrev.com/28978226297bc33a6ca73efb1a82271888a5a8fb Cr-Commit-Position: refs/heads/master@{#343269}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Add known md5 hash for files. #

Patch Set 3 : Add warning message when md5sum is wrong. #

Total comments: 2

Patch Set 4 : exit 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -0 lines) Patch
M build/install-build-deps-android.sh View 1 2 3 1 chunk +28 lines, -0 lines 0 comments Download

Messages

Total messages: 21 (7 generated)
navabi
This picks up from this CL: https://codereview.chromium.org/918043004/
5 years, 4 months ago (2015-08-13 01:18:47 UTC) #2
navabi
5 years, 4 months ago (2015-08-13 01:21:14 UTC) #4
kerz_chromium
lgtm
5 years, 4 months ago (2015-08-13 02:35:46 UTC) #5
Ryan Tseng
https://codereview.chromium.org/1287133002/diff/1/build/install-build-deps-android.sh File build/install-build-deps-android.sh (right): https://codereview.chromium.org/1287133002/diff/1/build/install-build-deps-android.sh#newcode106 build/install-build-deps-android.sh:106: /b/build/scripts/slave/gsutil cp ${gs_url} ${tmpfile} Can you validate this against ...
5 years, 4 months ago (2015-08-13 03:51:54 UTC) #7
navabi
PTAL https://codereview.chromium.org/1287133002/diff/1/build/install-build-deps-android.sh File build/install-build-deps-android.sh (right): https://codereview.chromium.org/1287133002/diff/1/build/install-build-deps-android.sh#newcode106 build/install-build-deps-android.sh:106: /b/build/scripts/slave/gsutil cp ${gs_url} ${tmpfile} On 2015/08/13 03:51:53, Ryan ...
5 years, 4 months ago (2015-08-13 17:39:34 UTC) #8
Ryan Tseng
https://codereview.chromium.org/1287133002/diff/40001/build/install-build-deps-android.sh File build/install-build-deps-android.sh (right): https://codereview.chromium.org/1287133002/diff/40001/build/install-build-deps-android.sh#newcode114 build/install-build-deps-android.sh:114: echo 'WARNING: Bad md5sum; not installing' ${bin} exit 1?
5 years, 4 months ago (2015-08-13 17:48:28 UTC) #9
navabi
ptal https://codereview.chromium.org/1287133002/diff/40001/build/install-build-deps-android.sh File build/install-build-deps-android.sh (right): https://codereview.chromium.org/1287133002/diff/40001/build/install-build-deps-android.sh#newcode114 build/install-build-deps-android.sh:114: echo 'WARNING: Bad md5sum; not installing' ${bin} On ...
5 years, 4 months ago (2015-08-13 18:08:27 UTC) #10
Ryan Tseng
lgtm
5 years, 4 months ago (2015-08-13 18:12:38 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1287133002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1287133002/60001
5 years, 4 months ago (2015-08-13 20:00:39 UTC) #14
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/87979)
5 years, 4 months ago (2015-08-13 20:09:54 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1287133002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1287133002/60001
5 years, 4 months ago (2015-08-13 20:36:41 UTC) #18
commit-bot: I haz the power
Committed patchset #4 (id:60001)
5 years, 4 months ago (2015-08-13 20:42:10 UTC) #19
commit-bot: I haz the power
Patchset 4 (id:??) landed as https://crrev.com/28978226297bc33a6ca73efb1a82271888a5a8fb Cr-Commit-Position: refs/heads/master@{#343269}
5 years, 4 months ago (2015-08-13 20:43:04 UTC) #20
navabi
5 years, 3 months ago (2015-08-29 23:45:37 UTC) #21
Message was sent while issue was closed.
A revert of this CL (patchset #4 id:60001) has been created in
https://codereview.chromium.org/1308953006/ by navabi@google.com.

The reason for reverting is: Chromium devs don't have gsutil or gsutil
credentials. install-build-deps-android.sh should be usable by public chromium
developers.

Also, apktool has since been checked into the chromium checkout, so we no longer
even need this..

Powered by Google App Engine
This is Rietveld 408576698