|
|
Created:
5 years, 4 months ago by navabi1 Modified:
5 years, 4 months ago Reviewers:
dba (chromium), Ryan Tseng, friedman, navabi, luqui, cjhopman, johnw, hinoka, kerz_chromium, pschmidt CC:
chromium-reviews Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionAdd apktool and apktool.jar to install-build-deps-android.sh
BUG=452927
TBR=cjhopman@chromium.org
Committed: https://crrev.com/28978226297bc33a6ca73efb1a82271888a5a8fb
Cr-Commit-Position: refs/heads/master@{#343269}
Patch Set 1 #
Total comments: 2
Patch Set 2 : Add known md5 hash for files. #Patch Set 3 : Add warning message when md5sum is wrong. #
Total comments: 2
Patch Set 4 : exit 1 #Messages
Total messages: 21 (7 generated)
This picks up from this CL: https://codereview.chromium.org/918043004/
navabi@google.com changed reviewers: + kerz@chromium.org
lgtm
hinoka@google.com changed reviewers: + hinoka@google.com
https://codereview.chromium.org/1287133002/diff/1/build/install-build-deps-an... File build/install-build-deps-android.sh (right): https://codereview.chromium.org/1287133002/diff/1/build/install-build-deps-an... build/install-build-deps-android.sh:106: /b/build/scripts/slave/gsutil cp ${gs_url} ${tmpfile} Can you validate this against a known hash? Since this is going to be executed as root on all the bots now, it might be good to make sure it can't be changed out from under us without our knowledge.
PTAL https://codereview.chromium.org/1287133002/diff/1/build/install-build-deps-an... File build/install-build-deps-android.sh (right): https://codereview.chromium.org/1287133002/diff/1/build/install-build-deps-an... build/install-build-deps-android.sh:106: /b/build/scripts/slave/gsutil cp ${gs_url} ${tmpfile} On 2015/08/13 03:51:53, Ryan Tseng wrote: > Can you validate this against a known hash? Since this is going to be executed > as root on all the bots now, it might be good to make sure it can't be changed > out from under us without our knowledge. Done.
https://codereview.chromium.org/1287133002/diff/40001/build/install-build-dep... File build/install-build-deps-android.sh (right): https://codereview.chromium.org/1287133002/diff/40001/build/install-build-dep... build/install-build-deps-android.sh:114: echo 'WARNING: Bad md5sum; not installing' ${bin} exit 1?
ptal https://codereview.chromium.org/1287133002/diff/40001/build/install-build-dep... File build/install-build-deps-android.sh (right): https://codereview.chromium.org/1287133002/diff/40001/build/install-build-dep... build/install-build-deps-android.sh:114: echo 'WARNING: Bad md5sum; not installing' ${bin} On 2015/08/13 17:48:28, Ryan Tseng wrote: > exit 1? Done.
lgtm
The CQ bit was checked by navabi@google.com
The patchset sent to the CQ was uploaded after l-g-t-m from kerz@chromium.org Link to the patchset: https://codereview.chromium.org/1287133002/#ps60001 (title: "exit 1")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1287133002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1287133002/60001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
The CQ bit was checked by navabi@google.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1287133002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1287133002/60001
Message was sent while issue was closed.
Committed patchset #4 (id:60001)
Message was sent while issue was closed.
Patchset 4 (id:??) landed as https://crrev.com/28978226297bc33a6ca73efb1a82271888a5a8fb Cr-Commit-Position: refs/heads/master@{#343269}
Message was sent while issue was closed.
A revert of this CL (patchset #4 id:60001) has been created in https://codereview.chromium.org/1308953006/ by navabi@google.com. The reason for reverting is: Chromium devs don't have gsutil or gsutil credentials. install-build-deps-android.sh should be usable by public chromium developers. Also, apktool has since been checked into the chromium checkout, so we no longer even need this.. |