Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(336)

Issue 1287113010: Make snapshot.h usable without objects-inl.h header. (Closed)

Created:
5 years, 4 months ago by Michael Starzinger
Modified:
5 years, 4 months ago
Reviewers:
Yang
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Make snapshot.h usable without objects-inl.h header. This CL us a pure refactoring that makes an empty compilation unit including just "snapshot.h" but not "objects-inl.h" compile without warnings or errors. This is needed to further reduce the header dependency tangle. R=yangguo@chromium.org Committed: https://crrev.com/8a8867d341b66eac303eb8baa6239a2f43181c79 Cr-Commit-Position: refs/heads/master@{#30270}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+110 lines, -94 lines) Patch
M src/snapshot/serialize.h View 6 chunks +8 lines, -85 lines 0 comments Download
M src/snapshot/serialize.cc View 5 chunks +94 lines, -0 lines 0 comments Download
M src/snapshot/snapshot.h View 2 chunks +1 line, -6 lines 0 comments Download
M src/snapshot/snapshot-common.cc View 1 chunk +7 lines, -0 lines 0 comments Download
M src/snapshot/snapshot-empty.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M src/snapshot/snapshot-external.cc View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 6 (1 generated)
Michael Starzinger
5 years, 4 months ago (2015-08-20 12:36:35 UTC) #1
Yang
On 2015/08/20 12:36:35, Michael Starzinger wrote: lgtm.
5 years, 4 months ago (2015-08-20 13:00:05 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1287113010/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1287113010/1
5 years, 4 months ago (2015-08-20 13:04:41 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 4 months ago (2015-08-20 13:06:03 UTC) #5
commit-bot: I haz the power
5 years, 4 months ago (2015-08-20 13:06:18 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/8a8867d341b66eac303eb8baa6239a2f43181c79
Cr-Commit-Position: refs/heads/master@{#30270}

Powered by Google App Engine
This is Rietveld 408576698