Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(104)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1287113006: Revert of Remove FOUC avoidance from BlockPainter and DeprecatedPaintLayerPainter. (Closed)

Created:
5 years, 4 months ago by esprehn
Modified:
5 years, 4 months ago
CC:
blink-reviews, blink-reviews-dom_chromium.org, blink-reviews-paint_chromium.org, Inactive, dglazkov+blink, dshwang, eae+blinkwatch, rwlbuis, sof, slimming-paint-reviews_chromium.org, vivekg_samsung, vivekg
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Revert of Remove FOUC avoidance from BlockPainter and DeprecatedPaintLayerPainter. (patchset #2 id:20001 of https://codereview.chromium.org/1297803002/ ) Reason for revert: Causes FOUC in iframes after the main frame has finished loading. Original issue's description: > Remove FOUC avoidance from BlockPainter and DeprecatedPaintLayerPainter. > > After r200515 we no longer start producing frames until the stylesheets > have loaded which means we will never attempt to paint with pending > sheets so we don't need the FOUC avoidance code that paints white. Lets > remove it. > > See: https://src.chromium.org/viewvc/blink?revision=200515&view=revision > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=200587 TBR=bmcquade@chromium.org,chrishtr@chromium.org,pdr@chromium.org,ojan@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=200731

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+62 lines, -1 line) Patch
M LayoutTests/TestExpectations View 1 chunk +1 line, -0 lines 0 comments Download
A LayoutTests/http/tests/fouc/scroll-left-while-loading.html View 1 chunk +21 lines, -0 lines 0 comments Download
A LayoutTests/http/tests/fouc/scroll-left-while-loading-expected.txt View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/dom/Document.h View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/dom/Document.cpp View 1 chunk +8 lines, -1 line 0 comments Download
M Source/core/paint/BlockPainter.cpp View 1 chunk +6 lines, -0 lines 0 comments Download
M Source/core/paint/DeprecatedPaintLayerPainter.cpp View 2 chunks +14 lines, -0 lines 0 comments Download
M Source/core/testing/Internals.h View 1 chunk +2 lines, -0 lines 0 comments Download
M Source/core/testing/Internals.cpp View 1 chunk +6 lines, -0 lines 0 comments Download
M Source/core/testing/Internals.idl View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
esprehn
Created Revert of Remove FOUC avoidance from BlockPainter and DeprecatedPaintLayerPainter.
5 years, 4 months ago (2015-08-18 17:10:23 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1287113006/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1287113006/1
5 years, 4 months ago (2015-08-18 17:10:41 UTC) #2
commit-bot: I haz the power
5 years, 4 months ago (2015-08-18 17:11:15 UTC) #3
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=200731

Powered by Google App Engine
This is Rietveld 408576698