Chromium Code Reviews

Issue 1287113002: Clean up PageBoundaryRule enum. (Closed)

Created:
5 years, 4 months ago by mstensho (USE GERRIT)
Modified:
5 years, 4 months ago
Reviewers:
leviw_travelin_and_unemployed
CC:
blink-reviews, blink-reviews-rendering, eae+blinkwatch, jchaffraix+rendering, leviw+renderwatch, pdr+renderingwatchlist_chromium.org, szager+layoutwatch_chromium.org, zoltan1
Target Ref:
refs/remotes/origin/master
Project:
blink
Visibility:
Public.

Description

Clean up PageBoundaryRule enum. Replace the {Include,Exclude}PageBoundary values with AssociateWith{Former,Latter}Page, since it was rather confusing what was meant by "include" or "exclude" in most situations. Also remove default PageBoundaryRule values from method declarations taking this enum as a parameter, since there's really no natural default value, and each caller should be aware of what it's asking for. Realizing what's actually going on here allowed for some cleanup in nextPageLogicalTop(). Also made the enum public, since there are public methods taking it as a parameter. No behavioral changes intended. R=leviw@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=200438

Patch Set 1 #

Unified diffs Side-by-side diffs Stats (+35 lines, -31 lines)
M Source/core/layout/LayoutBlock.h View 1 chunk +17 lines, -11 lines 0 comments
M Source/core/layout/LayoutBlock.cpp View 2 chunks +5 lines, -8 lines 0 comments
M Source/core/layout/LayoutBlockFlow.cpp View 7 chunks +7 lines, -7 lines 0 comments
M Source/core/layout/LayoutFlowThread.h View 1 chunk +1 line, -1 line 0 comments
M Source/core/layout/LayoutMultiColumnFlowThread.cpp View 1 chunk +1 line, -1 line 0 comments
M Source/core/layout/LayoutMultiColumnSet.cpp View 1 chunk +4 lines, -3 lines 0 comments

Messages

Total messages: 5 (1 generated)
mstensho (USE GERRIT)
5 years, 4 months ago (2015-08-12 21:01:06 UTC) #1
leviw_travelin_and_unemployed
lgtm This makes way more sense to me. Thanks for the cleanup!
5 years, 4 months ago (2015-08-12 21:59:42 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1287113002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1287113002/1
5 years, 4 months ago (2015-08-12 22:00:01 UTC) #4
commit-bot: I haz the power
5 years, 4 months ago (2015-08-12 23:46:04 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=200438

Powered by Google App Engine