ui/events/gesture_detection/scale_gesture_detector.cc - Issue 1287103004: Sync ui/events to chromium @ https://codereview.chromium.org/1210203002

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/events/gesture_detection/scale_gesture_detector.cc

Issue 1287103004: Sync ui/events to chromium @ https://codereview.chromium.org/1210203002 (Closed) Base URL: https://github.com/domokit/mojo.git@master

Patch Set: rebased Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « ui/events/gesture_detection/motion_event_generic_unittest.cc ('k') | ui/events/gesture_detection/snap_scroll_controller.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: ui/events/gesture_detection/scale_gesture_detector.cc

diff --git a/ui/events/gesture_detection/scale_gesture_detector.cc b/ui/events/gesture_detection/scale_gesture_detector.cc

index a8316c7cefeb291107bd26e852a1ace3eae21654..fb27cd9458e11829cb12669c70a6ddae165f1d4a 100644

--- a/ui/events/gesture_detection/scale_gesture_detector.cc

+++ b/ui/events/gesture_detection/scale_gesture_detector.cc

@@ -5,6 +5,7 @@

#include "ui/events/gesture_detection/scale_gesture_detector.h"

#include <limits.h>

#include <cmath>

#include "base/logging.h"

@@ -29,7 +30,8 @@ const float kScaleFactor = .5f;

} // namespace

// Note: These constants were taken directly from the default (unscaled)

-// versions found in Android's ViewConfiguration.

+// versions found in Android's ViewConfiguration. Do not change these default

+// values without explicitly consulting an OWNER.

ScaleGestureDetector::Config::Config()

: span_slop(16),

min_scaling_touch_major(48),