Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(481)

Unified Diff: ui/events/gesture_detection/velocity_tracker.h

Issue 1287103004: Sync ui/events to chromium @ https://codereview.chromium.org/1210203002 (Closed) Base URL: https://github.com/domokit/mojo.git@master
Patch Set: rebased Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ui/events/gesture_detection/velocity_tracker.h
diff --git a/ui/events/gesture_detection/velocity_tracker.h b/ui/events/gesture_detection/velocity_tracker.h
index 8147695dd2510c531074b7e3f0b17ba870fc0143..8a57150c4b8ee52effbc6af9a2627885a45e34ca 100644
--- a/ui/events/gesture_detection/velocity_tracker.h
+++ b/ui/events/gesture_detection/velocity_tracker.h
@@ -42,10 +42,20 @@ class VelocityTracker {
// 2nd order least squares. Quality: VERY GOOD.
// Pretty much ideal, but can be confused by certain kinds of touch data,
- // particularly if the panel has a tendency to generate delayed,
- // duplicate or jittery touch coordinates when the finger is released.
+ // particularly if the panel has a tendency to generate delayed, duplicate
+ // or jittery touch coordinates when the finger is released. This is the
+ // default velocity tracker strategy. Although other strategies are
+ // available for testing and comparison purposes, this is the strategy that
+ // applications will actually use. Be very careful when adjusting the
+ // default strategy because it can dramatically affect (often in a bad way)
+ // the user experience.
LSQ2,
+ // The same as LSQ2, but reports 0 if the direction of the velocity returned
+ // is sufficiently different from the primary direction of movement of the
+ // touches contributing to the velocity.
+ LSQ2_RESTRICTED,
+
// 3rd order least squares. Quality: UNUSABLE.
// Frequently overfits the touch data yielding wildly divergent estimates
// of the velocity when the finger is released.
@@ -78,16 +88,9 @@ class VelocityTracker {
STRATEGY_MAX = INT2,
// The default velocity tracker strategy.
- // Although other strategies are available for testing and comparison
- // purposes, this is the strategy that applications will actually use. Be
- // very careful when adjusting the default strategy because it can
- // dramatically affect (often in a bad way) the user experience.
STRATEGY_DEFAULT = LSQ2,
};
- // Creates a velocity tracker using the default strategy for the platform.
- VelocityTracker();
-
// Creates a velocity tracker using the specified strategy.
// If strategy is NULL, uses the default strategy for the platform.
explicit VelocityTracker(Strategy strategy);
@@ -133,8 +136,7 @@ class VelocityTracker {
const Position* positions);
// Gets an estimator for the recent movements of the specified pointer id.
- // Returns false and clears the estimator if there is no information available
- // about the pointer.
+ // Returns false if the pointer velocity is unknown.
bool GetEstimator(uint32_t id, Estimator* out_estimator) const;
base::TimeTicks last_event_time_;

Powered by Google App Engine
This is Rietveld 408576698