Source/bindings/core/v8/WorkerScriptController.h - Issue 1287103002: [Extension ServiceWorkers] Blink: Passing v8::context to extensions dispatcher

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/core/v8/WorkerScriptController.h

Issue 1287103002: [Extension ServiceWorkers] Blink: Passing v8::context to extensions dispatcher (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: change script()->scriptState()->contextIsValid to script()->isContextInitialized() Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/bindings/core/v8/WorkerScriptController.h

diff --git a/Source/bindings/core/v8/WorkerScriptController.h b/Source/bindings/core/v8/WorkerScriptController.h

index ecc540e5704110327c6c70de74f1080026605033..d1d53603909094705d540d55e650af3b81f4ca66 100644

--- a/Source/bindings/core/v8/WorkerScriptController.h

+++ b/Source/bindings/core/v8/WorkerScriptController.h

@@ -86,10 +86,11 @@ public:

RejectedPromises* rejectedPromises() const { return m_rejectedPromises.get(); }

+ bool isContextInitialized() { return m_scriptState && !!m_scriptState->perContextData(); }

private:

class WorkerGlobalScopeExecutionState;

- bool isContextInitialized() { return m_scriptState && !!m_scriptState->perContextData(); }

v8::Isolate* isolate() const;

// Evaluate a script file in the current execution environment.

« no previous file with comments | « no previous file | Source/core/workers/WorkerReportingProxy.h » ('j') | Source/web/ServiceWorkerGlobalScopeProxy.cpp » ('J')