SIMD plumbing

runtime/vm/isolate.h

 // Copyright (c) 2013, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #ifndef VM_ISOLATE_H_
 #define VM_ISOLATE_H_
 
 #include "include/dart_api.h"
 #include "platform/assert.h"
 #include "platform/thread.h"
@@ skipping 22 matching lines @@
 class RawArray;
 class RawContext;
 class RawDouble;
 class RawMint;
 class RawInteger;
 class RawError;
 class Simulator;
 class StackResource;
 class StackZone;
 class StubCode;
+class RawFloat32x4;
+class RawUint32x4;
 
 
 // Used by the deoptimization infrastructure to defer allocation of Double
 // objects until frame is fully rewritten and GC is safe.
 // See callers of Isolate::DeferDoubleMaterialization.
 class DeferredDouble {
  public:
   DeferredDouble(double value, RawDouble** slot, DeferredDouble* next)
       : value_(value), slot_(slot), next_(next) { }
 
@@ skipping 21 matching lines @@
 
  private:
   const int64_t value_;
   RawMint** const slot_;
   DeferredMint* const next_;
 
   DISALLOW_COPY_AND_ASSIGN(DeferredMint);
 };
 
 
+class DeferredFloat32x4 {

[Vyacheslav Egorov (Google), 2013/03/17 18:17:10]

This is a lot of code duplication. 

Suggestion: move generic parts (e.g. next and slot_) into Base class, declare a
virtual function for materialization. 

class DeferredFloat32x4 : public DeferredSlot {
  public:
    virtual void Materialize() { /* Allocate and store into slot */ }
  private:
    const simd128_value_t value_
};

instead of 4 lists have a single list.

[Cutch, 2013/03/17 21:52:37]

Done.

+ public:
+  DeferredFloat32x4(simd128_value_t value, RawFloat32x4** slot,
+                    DeferredFloat32x4* next)
+      : value_(value), slot_(slot), next_(next) { }
+
+  simd128_value_t value() const { return value_; }
+  RawFloat32x4** slot() const { return slot_; }
+  DeferredFloat32x4* next() const { return next_; }
+
+ private:
+  const simd128_value_t value_;
+  RawFloat32x4** const slot_;
+  DeferredFloat32x4* const next_;
+
+  DISALLOW_COPY_AND_ASSIGN(DeferredFloat32x4);
+};
+
+
+class DeferredUint32x4 {
+ public:
+  DeferredUint32x4(simd128_value_t value, RawUint32x4** slot,
+                   DeferredUint32x4* next)
+      : value_(value), slot_(slot), next_(next) { }
+
+  simd128_value_t value() const { return value_; }
+  RawUint32x4** slot() const { return slot_; }
+  DeferredUint32x4* next() const { return next_; }
+
+ private:
+  const simd128_value_t value_;
+  RawUint32x4** const slot_;
+  DeferredUint32x4* const next_;
+
+  DISALLOW_COPY_AND_ASSIGN(DeferredUint32x4);
+};
+
+
 class Isolate : public BaseIsolate {
  public:
   ~Isolate();
 
   static inline Isolate* Current() {
     return reinterpret_cast<Isolate*>(Thread::GetThreadLocal(isolate_key));
   }
 
   static void SetCurrent(Isolate* isolate);
 
@@ skipping 207 matching lines @@
     return file_close_callback_;
   }
 
   intptr_t* deopt_cpu_registers_copy() const {
     return deopt_cpu_registers_copy_;
   }
   void set_deopt_cpu_registers_copy(intptr_t* value) {
     ASSERT((value == NULL) || (deopt_cpu_registers_copy_ == NULL));
     deopt_cpu_registers_copy_ = value;
   }
-  double* deopt_fpu_registers_copy() const {
+  fpu_register_t* deopt_fpu_registers_copy() const {
     return deopt_fpu_registers_copy_;
   }
-  void set_deopt_fpu_registers_copy(double* value) {
+  void set_deopt_fpu_registers_copy(fpu_register_t* value) {
     ASSERT((value == NULL) || (deopt_fpu_registers_copy_ == NULL));
     deopt_fpu_registers_copy_ = value;
   }
   intptr_t* deopt_frame_copy() const { return deopt_frame_copy_; }
   void SetDeoptFrameCopy(intptr_t* value, intptr_t size) {
     ASSERT((value == NULL) || (size > 0));
     ASSERT((value == NULL) || (deopt_frame_copy_ == NULL));
     deopt_frame_copy_ = value;
     deopt_frame_copy_size_ = size;
   }
   intptr_t deopt_frame_copy_size() const { return deopt_frame_copy_size_; }
 
   void DeferDoubleMaterialization(double value, RawDouble** slot) {
     deferred_doubles_ = new DeferredDouble(value, slot, deferred_doubles_);
   }
 
   void DeferMintMaterialization(int64_t value, RawMint** slot) {
     deferred_mints_ = new DeferredMint(value, slot, deferred_mints_);
   }
 
+  void DeferFloat32x4Materialization(simd128_value_t value,
+                                     RawFloat32x4** slot) {
+    deferred_float32x4s_ = new DeferredFloat32x4(value, slot,
+                                                 deferred_float32x4s_);
+  }
+
+  void DeferUint32x4Materialization(simd128_value_t value,
+                                    RawUint32x4** slot) {
+    deferred_uint32x4s_ = new DeferredUint32x4(value, slot,
+                                               deferred_uint32x4s_);
+  }
+
   DeferredDouble* DetachDeferredDoubles() {
     DeferredDouble* list = deferred_doubles_;
     deferred_doubles_ = NULL;
     return list;
   }
 
   DeferredMint* DetachDeferredMints() {
     DeferredMint* list = deferred_mints_;
     deferred_mints_ = NULL;
     return list;
   }
 
+  DeferredFloat32x4* DetachDeferredFloat32x4s() {
+    DeferredFloat32x4* list = deferred_float32x4s_;
+    deferred_float32x4s_ = NULL;
+    return list;
+  }
+
+  DeferredUint32x4* DetachDeferredUint32x4s() {
+    DeferredUint32x4* list = deferred_uint32x4s_;
+    deferred_uint32x4s_ = NULL;
+    return list;
+  }
+
   static char* GetStatus(const char* request);
 
  private:
   Isolate();
 
   void BuildName(const char* name_prefix);
   void PrintInvokedFunctions();
 
   static ThreadLocalKey isolate_key;
   StoreBufferBlock store_buffer_block_;
@@ skipping 21 matching lines @@
   Mutex* mutex_;  // protects stack_limit_ and saved_stack_limit_.
   uword stack_limit_;
   uword saved_stack_limit_;
   MessageHandler* message_handler_;
   uword spawn_data_;
   GcPrologueCallbacks gc_prologue_callbacks_;
   GcEpilogueCallbacks gc_epilogue_callbacks_;
 
   // Deoptimization support.
   intptr_t* deopt_cpu_registers_copy_;
-  double* deopt_fpu_registers_copy_;
+  fpu_register_t* deopt_fpu_registers_copy_;
   intptr_t* deopt_frame_copy_;
   intptr_t deopt_frame_copy_size_;
   DeferredDouble* deferred_doubles_;
   DeferredMint* deferred_mints_;
+  DeferredFloat32x4* deferred_float32x4s_;
+  DeferredUint32x4* deferred_uint32x4s_;
 
   static Dart_IsolateCreateCallback create_callback_;
   static Dart_IsolateInterruptCallback interrupt_callback_;
   static Dart_IsolateUnhandledExceptionCallback unhandled_exception_callback_;
   static Dart_IsolateShutdownCallback shutdown_callback_;
   static Dart_FileOpenCallback file_open_callback_;
   static Dart_FileWriteCallback file_write_callback_;
   static Dart_FileCloseCallback file_close_callback_;
 
   DISALLOW_COPY_AND_ASSIGN(Isolate);
@@ skipping 59 matching lines @@
   Isolate* new_isolate_;
   Isolate* saved_isolate_;
   uword saved_stack_limit_;
 
   DISALLOW_COPY_AND_ASSIGN(SwitchIsolateScope);
 };
 
 }  // namespace dart
 
 #endif  // VM_ISOLATE_H_