DevTools: respect minimum width/height when resizing.

chrome/browser/devtools/devtools_window.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <algorithm>
 
 #include "base/command_line.h"
 #include "base/json/json_writer.h"
 #include "base/lazy_instance.h"
 #include "base/stringprintf.h"
@@ skipping 72 matching lines @@
 const char kPrefBottom[] = "dock_bottom";
 const char kPrefRight[] = "dock_right";
 const char kPrefUndocked[] = "undocked";
 
 const char kDockSideBottom[] = "bottom";
 const char kDockSideRight[] = "right";
 const char kDockSideUndocked[] = "undocked";
 
 // Minimal height of devtools pane or content pane when devtools are docked
 // to the browser window.
-const int kMinDevToolsHeight = 50;
+const int kMinDevToolsHeight = 23;

[pfeldman, 2013/03/19 10:42:06]

I'd leave this 50.

[dgozman, 2013/03/21 09:55:26]

Done.

 const int kMinDevToolsWidth = 150;
 const int kMinContentsSize = 50;
 
 class DevToolsWindow::InspectedWebContentsObserver
   : public content::WebContentsObserver {
  public:
   explicit InspectedWebContentsObserver(content::WebContents* web_contents)
     : WebContentsObserver(web_contents) {
     }
 
@@ skipping 285 matching lines @@
   // Respect the minimum devtools width preset.
   height_ = std::max(kMinDevToolsHeight, height_);
 
   // But it should never compromise the content window size.
   height_ = std::min(container_height - kMinContentsSize, height_);
   if (height_ < (kMinContentsSize / 2))
     height_ = container_height / 3;
   return height_;
 }
 
+int DevToolsWindow::GetMinimumWidth() {
+  return kMinDevToolsWidth;
+}
+
+int DevToolsWindow::GetMinimumHeight() {
+  return kMinDevToolsHeight;
+}
+
 void DevToolsWindow::SetWidth(int width) {
   width_ = width;
   profile_->GetPrefs()->SetInteger(prefs::kDevToolsVSplitLocation, width);
 }
 
 void DevToolsWindow::SetHeight(int height) {
   height_ = height;
   profile_->GetPrefs()->SetInteger(prefs::kDevToolsHSplitLocation, height);
 }
 
@@ skipping 624 matching lines @@
 
 // static
 DevToolsDockSide DevToolsWindow::SideFromString(
     const std::string& dock_side) {
   if (dock_side == kDockSideRight)
     return DEVTOOLS_DOCK_SIDE_RIGHT;
   if (dock_side == kDockSideBottom)
     return DEVTOOLS_DOCK_SIDE_BOTTOM;
   return DEVTOOLS_DOCK_SIDE_UNDOCKED;
 }