runtime/lib/string.cc - Issue 12871010: Replace scalarlist optimizations and split external array loads into two IL instructions.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/lib/string.cc

Issue 12871010: Replace scalarlist optimizations and split external array loads into two IL instructions. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Patch Set: Created 7 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: runtime/lib/string.cc

===================================================================

--- runtime/lib/string.cc (revision 20148)

+++ runtime/lib/string.cc (working copy)

@@ -215,8 +215,7 @@

DEFINE_NATIVE_ENTRY(StringBuffer_createStringFromUint16Array, 3) {

- GET_NON_NULL_NATIVE_ARGUMENT(Uint16Array, codeUnits,

- arguments->NativeArgAt(0));

+ GET_NON_NULL_NATIVE_ARGUMENT(TypedData, codeUnits, arguments->NativeArgAt(0));

GET_NON_NULL_NATIVE_ARGUMENT(Smi, length, arguments->NativeArgAt(1));

GET_NON_NULL_NATIVE_ARGUMENT(Bool, isLatin1, arguments->NativeArgAt(2));

intptr_t array_length = codeUnits.Length();

@@ -231,7 +230,7 @@

: String::Handle(TwoByteString::New(length_value, Heap::kNew));

NoGCScope no_gc;

- uint16_t* data_position = reinterpret_cast<uint16_t*>(codeUnits.ByteAddr(0));

+ uint16_t* data_position = reinterpret_cast<uint16_t*>(codeUnits.DataAddr(0));

String::Copy(result, 0, data_position, length_value);

return result.raw();

}

« no previous file with comments | « runtime/lib/math_patch.dart ('k') | runtime/platform/assert.h » ('j') | no next file with comments »