Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(88)

Issue 12871008: Revert 188253 "Reenable test ExtensionApiTest.UpdateWindowShowSt..." (Closed)

Created:
7 years, 9 months ago by Finnur
Modified:
7 years, 9 months ago
Reviewers:
jianli
CC:
chromium-reviews, Aaron Boodman, chromium-apps-reviews_chromium.org
Visibility:
Public.

Description

Revert 188253 "Reenable test ExtensionApiTest.UpdateWindowShowSt..." Still fails. See: http://build.chromium.org/p/chromium.win/waterfall?builder=Win7%20Tests%20(dbg)(6) > Reenable test ExtensionApiTest.UpdateWindowShowState for Windows > > This test was disabled some time ago. I did not find the suspicious patch in the range that could cause the failure. I enabled it and ran it locally and on trybot and it does not fail. > > BUG=176683 > TEST=this is a test > > Review URL: https://chromiumcodereview.appspot.com/12408008 TBR=jianli@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=188316

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -2 lines) Patch
M chrome/browser/extensions/extension_tabs_apitest.cc View 1 chunk +3 lines, -2 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Finnur
7 years, 9 months ago (2013-03-15 09:26:46 UTC) #1
Finnur
7 years, 9 months ago (2013-03-15 09:26:58 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 manually as r188316.

Powered by Google App Engine
This is Rietveld 408576698