Issue 12871005: Merge 188114 "Revert 173932 "Fix bug where extension popups woul..."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 12871005: Merge 188114 "Revert 173932 "Fix bug where extension popups woul..." (Closed)

Created:
7 years, 9 months ago by Matt Perry

Modified:
7 years, 9 months ago

Reviewers:
mpcomplete

CC:
chromium-reviews, Aaron Boodman, tfarina, chromium-apps-reviews_chromium.org

Base URL:
svn://svn.chromium.org/chrome/branches/1410/src/

Visibility:
Public.

Merge 188114 "Revert 173932 "Fix bug where extension popups woul..." > Revert 173932 "Fix bug where extension popups would not properly..." > It breaks popup sizing with threaded compositing enabled. > > > Fix bug where extension popups would not properly receive input focus when > > first shown. > > > > BUG=122352 > > TBR=sky@chromium.org > > > > Review URL: https://chromiumcodereview.appspot.com/11644006 > > BUG=181559 > TBR=mpcomplete@chromium.org > Review URL: https://codereview.chromium.org/12825007 TBR=mpcomplete@google.com Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=188152

Created: 7 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -4 lines)			Patch
	M	chrome/browser/ui/views/extensions/extension_popup.cc	View		1 chunk	+0 lines, -4 lines	0 comments	Download

Total messages: 2 (0 generated)

Message was sent while issue was closed.

Committed patchset #1 manually as r188152.