Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(758)

Issue 1287063007: Certificate Transparency: Add Symantec's log (Closed)

Created:
5 years, 4 months ago by Eran Messeri
Modified:
5 years, 4 months ago
Reviewers:
davidben
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Certificate Transparency: Add Symantec's log Symantec's log has been monitored for the required period and was found compliant. BUG=483625 Committed: https://crrev.com/9563016b34d5518b1fb14c903170606797c3db26 Cr-Commit-Position: refs/heads/master@{#343873}

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -2 lines) Patch
M net/cert/ct_known_logs_static.h View 1 chunk +10 lines, -2 lines 2 comments Download

Messages

Total messages: 13 (4 generated)
Eran Messeri
David, kindly review Symantec's log addition. Ryan has approved over email but is not around ...
5 years, 4 months ago (2015-08-17 21:06:06 UTC) #2
davidben
https://codereview.chromium.org/1287063007/diff/1/net/cert/ct_known_logs_static.h File net/cert/ct_known_logs_static.h (right): https://codereview.chromium.org/1287063007/diff/1/net/cert/ct_known_logs_static.h#newcode73 net/cert/ct_known_logs_static.h:73: const size_t kNumKnownCTLogs = 7; If you #include "base/macros.h", ...
5 years, 4 months ago (2015-08-17 21:11:56 UTC) #3
davidben
(Oh, and lgtm)
5 years, 4 months ago (2015-08-17 21:12:43 UTC) #4
davidben
https://codereview.chromium.org/1287063007/diff/1/net/cert/ct_known_logs_static.h File net/cert/ct_known_logs_static.h (right): https://codereview.chromium.org/1287063007/diff/1/net/cert/ct_known_logs_static.h#newcode73 net/cert/ct_known_logs_static.h:73: const size_t kNumKnownCTLogs = 7; On 2015/08/17 21:11:55, David ...
5 years, 4 months ago (2015-08-17 21:14:05 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1287063007/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1287063007/1
5 years, 4 months ago (2015-08-17 21:15:30 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/99261)
5 years, 4 months ago (2015-08-17 23:40:49 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1287063007/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1287063007/1
5 years, 4 months ago (2015-08-18 10:05:15 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 4 months ago (2015-08-18 10:08:46 UTC) #12
commit-bot: I haz the power
5 years, 4 months ago (2015-08-18 10:09:33 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/9563016b34d5518b1fb14c903170606797c3db26
Cr-Commit-Position: refs/heads/master@{#343873}

Powered by Google App Engine
This is Rietveld 408576698