Clear m_webMediaPlayer at one place in HTMLMediaElement

Clear m_webMediaPlayer at one place in HTMLMediaElement

Currently m_webMediaPlayer is cleared in resetMediaPlayerAndMediaSource
and clearMediaPlayerAndAudioSourceProviderClientWithoutLocking. So
reusing clearMediaPlayerAndAudioSourceProviderClientWithoutLocking
in resetMediaPlayerAndMediaSource.

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=200720

[Srirama, 2015-08-17 13:49:21]

Tried to refactor resetMediaPlayerAndMediaSource as well but looks like i need
to dig a bit more deeper.

[Srirama, 2015-08-17 13:50:00]

srirama.m@samsung.com changed reviewers:
+ philipj@opera.com

[philipj_slow, 2015-08-18 07:53:50]

https://codereview.chromium.org/1287063006/diff/1/Source/core/html/HTMLMediaE...
File Source/core/html/HTMLMediaElement.cpp (right):

https://codereview.chromium.org/1287063006/diff/1/Source/core/html/HTMLMediaE...
Source/core/html/HTMLMediaElement.cpp:3485: AudioSourceProviderClientLockScope
scope(*this);
Maybe wrap this in a scope like in HTMLMediaElement::clearMediaPlayer?

Also, this will call audioSourceProvider().setClient(nullptr) which didn't
happen before. Does that matter?

[Srirama, 2015-08-18 08:38:33]

https://codereview.chromium.org/1287063006/diff/1/Source/core/html/HTMLMediaE...
File Source/core/html/HTMLMediaElement.cpp (right):

https://codereview.chromium.org/1287063006/diff/1/Source/core/html/HTMLMediaE...
Source/core/html/HTMLMediaElement.cpp:3485: AudioSourceProviderClientLockScope
scope(*this);
On 2015/08/18 07:53:50, philipj wrote:
> Maybe wrap this in a scope like in HTMLMediaElement::clearMediaPlayer?
> 
> Also, this will call audioSourceProvider().setClient(nullptr) which didn't
> happen before. Does that matter?

That will be an extra call but there shouldn't be any functionality difference
as we are calling audioSourceProvider().setClient(m_audioSourceNode); at the end
of this function.

[philipj_slow, 2015-08-18 09:00:48]

The CQ bit was checked by philipj@opera.com

[philipj_slow, 2015-08-18 09:00:49]

lgtm

https://codereview.chromium.org/1287063006/diff/1/Source/core/html/HTMLMediaE...
File Source/core/html/HTMLMediaElement.cpp (right):

https://codereview.chromium.org/1287063006/diff/1/Source/core/html/HTMLMediaE...
Source/core/html/HTMLMediaElement.cpp:3485: AudioSourceProviderClientLockScope
scope(*this);
On 2015/08/18 08:38:33, Srirama wrote:
> On 2015/08/18 07:53:50, philipj wrote:
> > Maybe wrap this in a scope like in HTMLMediaElement::clearMediaPlayer?
> > 
> > Also, this will call audioSourceProvider().setClient(nullptr) which didn't
> > happen before. Does that matter?
> 
> That will be an extra call but there shouldn't be any functionality difference
> as we are calling audioSourceProvider().setClient(m_audioSourceNode); at the
end
> of this function.

Oh, I didn't see that in the diff.

[commit-bot: I haz the power, 2015-08-18 09:01:06]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1287063006/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1287063006/20001

[commit-bot: I haz the power, 2015-08-18 10:41:40]

Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=200720