Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(185)

Issue 1287053007: Move rootUserSelectAllForNode() to EditingStrategy template class from PositionAlgorithm template cl (Closed)

Created:
5 years, 4 months ago by yosin_UTC9
Modified:
5 years, 4 months ago
Reviewers:
yoichio, hajimehoshi
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Move rootUserSelectAllForNode() to EditingStrategy template class from PositionAlgorithm template class This patch moves |rootUserSelectAllForNode()| to |EditingStrategy| template class from |PositionAlgorithm| template class to simplify |PositionAlgorithm| class for improving code health, since an implementation of |rootUserSelectAllForNode()| is independent from |PositionAlgorithm|. BUG=518738 TEST=n/a; no behavior changes Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=200899

Patch Set 1 : 2015-08-20T17:38:38 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -31 lines) Patch
M Source/core/editing/EditingStrategy.h View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/editing/EditingStrategy.cpp View 1 chunk +23 lines, -0 lines 0 comments Download
M Source/core/editing/FrameSelection.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/editing/Position.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/editing/Position.cpp View 1 chunk +0 lines, -23 lines 0 comments Download
M Source/core/editing/SelectionController.cpp View 3 chunks +7 lines, -6 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
yosin_UTC9
PTAL
5 years, 4 months ago (2015-08-20 08:58:31 UTC) #2
hajimehoshi
lgtm
5 years, 4 months ago (2015-08-20 11:10:45 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1287053007/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1287053007/1
5 years, 4 months ago (2015-08-20 11:22:15 UTC) #5
commit-bot: I haz the power
5 years, 4 months ago (2015-08-20 12:25:08 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=200899

Powered by Google App Engine
This is Rietveld 408576698