Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(142)

Issue 1287033002: [runtime] Simplify CHECK_OBJECT_COERCIBLE. (Closed)

Created:
5 years, 4 months ago by Benedikt Meurer
Modified:
5 years, 4 months ago
Reviewers:
Yang
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[runtime] Simplify CHECK_OBJECT_COERCIBLE. Don't use IS_NULL_OR_UNDEFINED() for CHECK_OBJECT_COERCIBLE() because it will also return true for undetectable objects, but use IS_NULL() and IS_UNDEFINED() directly, which will only return true for null or undefined (which matches the semantics of the abstract operation CheckObjectCoercible). R=yangguo@chromium.org Committed: https://crrev.com/a7d22de460715df97b2b0f4838a505fe3f45ac46 Cr-Commit-Position: refs/heads/master@{#30129}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M src/macros.py View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (1 generated)
Benedikt Meurer
5 years, 4 months ago (2015-08-12 10:46:11 UTC) #1
Benedikt Meurer
Hey Yang, This is an obvious one. Please take a look. Thanks, Benedikt
5 years, 4 months ago (2015-08-12 10:46:32 UTC) #2
Yang
On 2015/08/12 10:46:11, Benedikt Meurer wrote: lgtm.
5 years, 4 months ago (2015-08-12 10:46:50 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1287033002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1287033002/1
5 years, 4 months ago (2015-08-12 10:47:03 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 4 months ago (2015-08-12 11:11:36 UTC) #6
commit-bot: I haz the power
5 years, 4 months ago (2015-08-12 11:11:46 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a7d22de460715df97b2b0f4838a505fe3f45ac46
Cr-Commit-Position: refs/heads/master@{#30129}

Powered by Google App Engine
This is Rietveld 408576698