Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2576)

Unified Diff: dart/tools/testing/dart/utils.dart

Issue 128703002: Cancel stdout/stderr subscriptions once subprocesses are dead, add more debugging information in ca… (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « dart/tools/testing/dart/test_runner.dart ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: dart/tools/testing/dart/utils.dart
diff --git a/dart/tools/testing/dart/utils.dart b/dart/tools/testing/dart/utils.dart
index b4455fa1a6042d7bc17e51a95b8d8c9eb934cc42..cb3f802d0b3ffbe1b83aeba4d2b1d75e02c179f9 100644
--- a/dart/tools/testing/dart/utils.dart
+++ b/dart/tools/testing/dart/utils.dart
@@ -10,6 +10,15 @@ import 'dart:convert';
part 'legacy_path.dart';
+// This is the maximum time we expect stdout/stderr of subprocesses to deliver
+// data after we've got the exitCode.
+const Duration MAX_STDIO_DELAY = const Duration(seconds: 30);
+
+String MAX_STDIO_DELAY_PASSED_MESSAGE =
+"""Not waiting for stdout/stderr from subprocess anymore
+($MAX_STDIO_DELAY passed). Please note that this could be an indicator
+that there is a hanging process which we were unable to kill.""";
+
class DebugLogger {
static IOSink _sink;
« no previous file with comments | « dart/tools/testing/dart/test_runner.dart ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698