Browser tests for the ChromeOS chromecast system tray item.

Browser tests for the ChromeOS chromecast system tray item.

This was initially reviewed in https://codereview.chromium.org/1231593002/. I've
moved this to a new CL since there have been a few implementation changes and as
a result this needs another look.

BUG=497343, 514952
Committed: https://crrev.com/926097380c61018aa2d5dfc99299f592ccfa5738
Cr-Commit-Position: refs/heads/master@{#344939}

[jdufault, 2015-08-14 21:58:16]

jdufault@chromium.org changed reviewers:
+ achuith@chromium.org, oshima@chromium.org

[jdufault, 2015-08-14 22:15:30]

Achuith and Oshima, would you mind taking a look? Thanks!

I created a new CL because I made significant changes to background.js and was
able to simplify parts of the browser test itself. If you would prefer, I can
delete this CL and upload to the old one instead.

[oshima, 2015-08-18 02:07:33]

On 2015/08/14 22:15:30, jdufault wrote:
> Achuith and Oshima, would you mind taking a look? Thanks!
> 
> I created a new CL because I made significant changes to background.js and was
> able to simplify parts of the browser test itself. If you would prefer, I can
> delete this CL and upload to the old one instead.

Either way is fine, but when you create a new CL, it'd be better to upload the
old one first, then
new one so that reviewers can easily see the difference.

[jdufault, 2015-08-18 18:24:19]

Patchset #1 (id:1) has been deleted

[jdufault, 2015-08-18 18:24:44]

On 2015/08/18 02:07:33, oshima (In Tokyo 17th - 21st) wrote:
> On 2015/08/14 22:15:30, jdufault wrote:
> > Achuith and Oshima, would you mind taking a look? Thanks!
> > 
> > I created a new CL because I made significant changes to background.js and
was
> > able to simplify parts of the browser test itself. If you would prefer, I
can
> > delete this CL and upload to the old one instead.
> 
> Either way is fine, but when you create a new CL, it'd be better to upload the
> old one first, then
> new one so that reviewers can easily see the difference.

Ok, I've reworked the patches so that patch #1 is the original CL, and patch #2
is the new code. Thanks

[oshima, 2015-08-19 00:34:21]

c/b/ui/ash lgtm with nits.

I'll leave js/json to achuithb@.

https://codereview.chromium.org/1287023010/diff/40001/chrome/browser/ui/ash/s...
File chrome/browser/ui/ash/system_tray_tray_cast_browsertest_chromeos.cc
(right):

https://codereview.chromium.org/1287023010/diff/40001/chrome/browser/ui/ash/s...
chrome/browser/ui/ash/system_tray_tray_cast_browsertest_chromeos.cc:38: }
new line between 38 and 39, and 45 and 46.

https://codereview.chromium.org/1287023010/diff/40001/chrome/browser/ui/ash/s...
chrome/browser/ui/ash/system_tray_tray_cast_browsertest_chromeos.cc:43:
CHECK(value->GetAsString(&result));
Just FYI: DCHECK is effective on release build on bots because they have
DCHECK_ALWAYS_ON.

I'm fine with either way as this is test only though.

[achuithb, 2015-08-19 17:34:38]

lgtm

https://codereview.chromium.org/1287023010/diff/40001/chrome/browser/ui/ash/s...
File chrome/browser/ui/ash/system_tray_tray_cast_browsertest_chromeos.cc
(right):

https://codereview.chromium.org/1287023010/diff/40001/chrome/browser/ui/ash/s...
chrome/browser/ui/ash/system_tray_tray_cast_browsertest_chromeos.cc:43:
CHECK(value->GetAsString(&result));
On 2015/08/19 00:34:21, oshima (In Tokyo 17th - 21st) wrote:
> Just FYI: DCHECK is effective on release build on bots because they have
> DCHECK_ALWAYS_ON.
> 
> I'm fine with either way as this is test only though.

Yup, believe DCHECK works, so we should use DCHECK.

https://codereview.chromium.org/1287023010/diff/40001/chrome/browser/ui/ash/s...
chrome/browser/ui/ash/system_tray_tray_cast_browsertest_chromeos.cc:50:
CHECK(value->GetAsBoolean(&result));
Same

[jdufault, 2015-08-19 18:38:28]

https://codereview.chromium.org/1287023010/diff/40001/chrome/browser/ui/ash/s...
File chrome/browser/ui/ash/system_tray_tray_cast_browsertest_chromeos.cc
(right):

https://codereview.chromium.org/1287023010/diff/40001/chrome/browser/ui/ash/s...
chrome/browser/ui/ash/system_tray_tray_cast_browsertest_chromeos.cc:38: }
On 2015/08/19 00:34:21, oshima (In Tokyo 17th - 21st) wrote:
> new line between 38 and 39, and 45 and 46.

Done.

https://codereview.chromium.org/1287023010/diff/40001/chrome/browser/ui/ash/s...
chrome/browser/ui/ash/system_tray_tray_cast_browsertest_chromeos.cc:43:
CHECK(value->GetAsString(&result));
On 2015/08/19 00:34:21, oshima (In Tokyo 17th - 21st) wrote:
> Just FYI: DCHECK is effective on release build on bots because they have
> DCHECK_ALWAYS_ON.
> 
> I'm fine with either way as this is test only though.

Done.

https://codereview.chromium.org/1287023010/diff/40001/chrome/browser/ui/ash/s...
chrome/browser/ui/ash/system_tray_tray_cast_browsertest_chromeos.cc:50:
CHECK(value->GetAsBoolean(&result));
On 2015/08/19 17:34:38, achuithb wrote:
> Same

Done.

[jdufault, 2015-08-21 19:13:16]

The CQ bit was checked by jdufault@chromium.org

[jdufault, 2015-08-21 19:13:16]

The patchset sent to the CQ was uploaded after l-g-t-m from
achuith@chromium.org, oshima@chromium.org
Link to the patchset: https://codereview.chromium.org/1287023010/#ps60001
(title: "Style fixes")

[commit-bot: I haz the power, 2015-08-21 19:14:35]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1287023010/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1287023010/60001

[commit-bot: I haz the power, 2015-08-21 20:24:51]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-08-21 20:24:52]

Try jobs failed on following builders:
  ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator...)

[jdufault, 2015-08-21 20:33:17]

The CQ bit was checked by jdufault@chromium.org

[commit-bot: I haz the power, 2015-08-21 20:33:33]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1287023010/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1287023010/60001

[commit-bot: I haz the power, 2015-08-21 21:07:32]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-08-21 21:07:32]

Try jobs failed on following builders:
  ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator...)

[jdufault, 2015-08-22 00:01:02]

The CQ bit was checked by jdufault@chromium.org

[commit-bot: I haz the power, 2015-08-22 00:02:37]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1287023010/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1287023010/60001

[commit-bot: I haz the power, 2015-08-22 00:38:05]

Committed patchset #3 (id:60001)

[commit-bot: I haz the power, 2015-08-22 00:38:51]

Patchset 3 (id:??) landed as
https://crrev.com/926097380c61018aa2d5dfc99299f592ccfa5738
Cr-Commit-Position: refs/heads/master@{#344939}

[Dan Beam, 2015-08-22 01:44:29]

A revert of this CL (patchset #3 id:60001) has been created in
https://codereview.chromium.org/1307863004/ by dbeam@chromium.org.

The reason for reverting is: broke the compile on ChromeOS bots:

FAILED: ...
../../chrome/browser/ui/ash/system_tray_tray_cast_browsertest_chromeos.cc:53:10:
error: variable 'result' is uninitialized when used here
[-Werror,-Wuninitialized]
  return result;
         ^~~~~~
../../chrome/browser/ui/ash/system_tray_tray_cast_browsertest_chromeos.cc:51:14:
note: initialize the variable 'result' to silence this warning
  bool result;
             ^
              = false.