Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(234)

Issue 1287023003: Add a info flag set when certs fails to conform to the CT policy. (Closed)

Created:
5 years, 4 months ago by haavardm
Modified:
5 years, 4 months ago
Reviewers:
Ryan Sleevi
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add a info flag set when certs fails to conform to the CT policy. This is useful for clients that only wants to show CT info if the certificate is not CT compliant. BUG=None Committed: https://crrev.com/533c27ba8a0b02ec7c38d574f3b1b744edf06abe Cr-Commit-Position: refs/heads/master@{#343170}

Patch Set 1 #

Patch Set 2 : Expect CT failure in unit test #

Patch Set 3 : Fix typo #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -1 line) Patch
M net/cert/cert_status_flags_list.h View 1 chunk +1 line, -0 lines 0 comments Download
M net/quic/crypto/proof_verifier_chromium.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M net/quic/crypto/proof_verifier_chromium_test.cc View 1 2 1 chunk +3 lines, -1 line 0 comments Download
M net/socket/ssl_client_socket_nss.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M net/socket/ssl_client_socket_openssl.cc View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
haavardm
Ryan, please review.
5 years, 4 months ago (2015-08-12 11:26:17 UTC) #2
Ryan Sleevi
lgtm
5 years, 4 months ago (2015-08-12 18:07:43 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1287023003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1287023003/1
5 years, 4 months ago (2015-08-12 18:08:06 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator_ninja/builds/55903)
5 years, 4 months ago (2015-08-12 18:42:01 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1287023003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1287023003/40001
5 years, 4 months ago (2015-08-13 09:23:08 UTC) #10
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 4 months ago (2015-08-13 09:27:34 UTC) #11
commit-bot: I haz the power
5 years, 4 months ago (2015-08-13 09:28:10 UTC) #12
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/533c27ba8a0b02ec7c38d574f3b1b744edf06abe
Cr-Commit-Position: refs/heads/master@{#343170}

Powered by Google App Engine
This is Rietveld 408576698