Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(90)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1287023002: fix StrDup memory leak in CcTest (Closed)

Created:
5 years, 4 months ago by jianghua
Modified:
5 years, 4 months ago
CC:
v8-dev
Base URL:
https://github.com/v8/v8-git-mirror@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

fix StrDup memory leak in CcTest BUG= Committed: https://crrev.com/94ee6b1ba207e77848a2d37e0b6324c63933d97c Cr-Commit-Position: refs/heads/master@{#30191}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M test/cctest/cctest.h View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
jianghua
On 2015/08/14 07:58:28, jianghua wrote: > mailto:jianghua.yjh@alibaba-inc.com changed reviewers: > + mailto:jochen@chromium.org > - mailto:yangguo@chromium.org ...
5 years, 4 months ago (2015-08-17 02:40:37 UTC) #4
Jakob Kummerow
lgtm
5 years, 4 months ago (2015-08-17 11:05:11 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1287023002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1287023002/1
5 years, 4 months ago (2015-08-17 11:05:14 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 4 months ago (2015-08-17 11:30:33 UTC) #8
commit-bot: I haz the power
5 years, 4 months ago (2015-08-17 11:30:45 UTC) #9
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/94ee6b1ba207e77848a2d37e0b6324c63933d97c
Cr-Commit-Position: refs/heads/master@{#30191}

Powered by Google App Engine
This is Rietveld 408576698