Issue 1286973004: Update codereview.settings for CQ.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1286973004: Update codereview.settings for CQ. (Closed)

Created:
5 years, 4 months ago by tandrii(chromium)

Modified:
5 years, 4 months ago

Reviewers:
Sergiy Byelozyorov, Paweł Hajdan Jr.

CC:
chromium-reviews, infra-reviews+luci-gae_chromium.org

Base URL:
https://github.com/luci/gae@master

Target Ref:
refs/heads/master

Project:
luci-gae

Visibility:
Public.

Created: 5 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -2 lines)			Patch
	M	codereview.settings	View	1	1 chunk	+3 lines, -2 lines	0 comments	Download

Total messages: 6 (0 generated)

Sergiy Byelozyorov

lgtm What's this new luci-gae project? Are we moving all GAE Luci apps there?

5 years, 4 months ago (2015-08-20 15:24:35 UTC) #3

tandrii(chromium)

On 2015/08/20 15:24:35, Sergiy Byelozyorov wrote: > lgtm > > What's this new luci-gae project? ...

5 years, 4 months ago (2015-08-20 15:26:06 UTC) #4

Sergiy Byelozyorov

On 2015/08/20 15:26:06, tandrii(chromium) wrote: > On 2015/08/20 15:24:35, Sergiy Byelozyorov wrote: > > lgtm ...

5 years, 4 months ago (2015-08-20 15:27:02 UTC) #5

tandrii(chromium)

5 years, 4 months ago (2015-08-20 15:42:02 UTC) #6

Message was sent while issue was closed.

Committed patchset #2 (id:20001) manually as
5a3d8ab8c4a6e8ddc2b2a8cc5efe3a97fd1baf13 (presubmit successful).