Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(39)

Issue 1286973002: Deprecate enable-background property (Closed)

Created:
5 years, 4 months ago by Shanmuga Pandi
Modified:
5 years, 4 months ago
Reviewers:
pdr., rwlbuis
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Deprecate enable-background property This feature has been deprecated in Filter Effects level 1: http://dev.w3.org/fxtf/filters/#AccessBackgroundImage BUG=507615 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=200597

Patch Set 1 #

Patch Set 2 : fixed unit-test failures #

Patch Set 3 : fixed failures #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -14 lines) Patch
M LayoutTests/virtual/stable/webexposed/css-properties-as-js-properties-expected.txt View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/webexposed/css-properties-as-js-properties-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/css/CSSProperties.in View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/css/ComputedStyleCSSValueMapping.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/css/SVGCSSValueKeywords.in View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/css/parser/CSSPropertyParser.cpp View 1 chunk +0 lines, -6 lines 0 comments Download
M Source/core/frame/UseCounter.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGAttributeNames.in View 1 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/svg/SVGElement.cpp View 1 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 27 (9 generated)
Shanmuga Pandi
Please review it..
5 years, 4 months ago (2015-08-12 05:40:54 UTC) #2
rwlbuis
On 2015/08/12 05:40:54, Shanmuga Pandi wrote: > Please review it.. Looks good to moi. Let's ...
5 years, 4 months ago (2015-08-12 21:00:59 UTC) #3
rwlbuis
On 2015/08/12 21:00:59, rwlbuis wrote: > On 2015/08/12 05:40:54, Shanmuga Pandi wrote: > > Please ...
5 years, 4 months ago (2015-08-13 15:35:47 UTC) #4
rwlbuis
On 2015/08/13 15:35:47, rwlbuis wrote: > On 2015/08/12 21:00:59, rwlbuis wrote: > > On 2015/08/12 ...
5 years, 4 months ago (2015-08-13 15:36:47 UTC) #6
pdr.
On 2015/08/13 at 15:36:47, rob.buis wrote: > On 2015/08/13 15:35:47, rwlbuis wrote: > > On ...
5 years, 4 months ago (2015-08-14 05:48:10 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1286973002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1286973002/40001
5 years, 4 months ago (2015-08-14 05:48:51 UTC) #9
pdr.
On 2015/08/14 at 05:48:10, pdr wrote: > On 2015/08/13 at 15:36:47, rob.buis wrote: > > ...
5 years, 4 months ago (2015-08-14 05:50:29 UTC) #10
Shanmuga Pandi
On 2015/08/14 05:50:29, pdr wrote: > On 2015/08/14 at 05:48:10, pdr wrote: > > On ...
5 years, 4 months ago (2015-08-14 07:33:09 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/93152)
5 years, 4 months ago (2015-08-14 08:20:07 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1286973002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1286973002/40001
5 years, 4 months ago (2015-08-14 08:32:49 UTC) #15
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/93196)
5 years, 4 months ago (2015-08-14 09:44:14 UTC) #17
Shanmuga Pandi
On 2015/08/14 09:44:14, commit-bot: I haz the power wrote: > Try jobs failed on following ...
5 years, 4 months ago (2015-08-14 09:54:57 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1286973002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1286973002/40001
5 years, 4 months ago (2015-08-14 15:11:02 UTC) #20
rwlbuis
On 2015/08/14 09:54:57, Shanmuga Pandi wrote: > On 2015/08/14 09:44:14, commit-bot: I haz the power ...
5 years, 4 months ago (2015-08-14 15:11:06 UTC) #21
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/93309)
5 years, 4 months ago (2015-08-14 17:21:43 UTC) #23
rwlbuis
On 2015/08/14 17:21:43, commit-bot: I haz the power wrote: > Try jobs failed on following ...
5 years, 4 months ago (2015-08-14 21:09:23 UTC) #24
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1286973002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1286973002/40001
5 years, 4 months ago (2015-08-15 04:08:57 UTC) #26
commit-bot: I haz the power
5 years, 4 months ago (2015-08-15 04:59:22 UTC) #27
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=200597

Powered by Google App Engine
This is Rietveld 408576698