impl/memory/datastore_index.go - Issue 1286943002: impl/memory: Make queries self-validate

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: impl/memory/datastore_index.go

Issue 1286943002: impl/memory: Make queries self-validate (Closed) Base URL: https://github.com/luci/gae.git@add_datastore_testable

Patch Set: add doc Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: impl/memory/datastore_index.go

diff --git a/impl/memory/datastore_index.go b/impl/memory/datastore_index.go

index 46c2ec5173c92f6b283ba55edebd77ba8ef02c92..1fb4c0ea95727ee1cdd0becb7c4e788d7ed4ac53 100644

--- a/impl/memory/datastore_index.go

+++ b/impl/memory/datastore_index.go

@@ -165,6 +165,9 @@ func (m *matcher) match(idx *ds.IndexDefinition, sip serializedIndexablePmap) (i

m.buf.propVec = m.buf.propVec[:0]

m.buf.orders = m.buf.orders[:0]

for _, sb := range idx.SortBy {

+ if sb.Property == "__key__" {

+ panic("don't know how to build compound index on __key__")

+ }

if pv, ok := sip[sb.Property]; ok {

m.buf.propVec = append(m.buf.propVec, pv)

m.buf.orders = append(m.buf.orders, sb.Direction)