Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(236)

Issue 1286923002: Add class to existing lexical scoping tests (Closed)

Created:
5 years, 4 months ago by Dan Ehrenberg
Modified:
5 years, 4 months ago
Reviewers:
adamk
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Add class to existing lexical scoping tests This patch strengthens testing of classes by verifying that the binding that they export externally follows block scoping, as opposed to var-style scoping. The tests are based on existing tests for let and const. R=adamk LOG=N BUG=v8:3305 Committed: https://crrev.com/e261540b9ee3182451faac7fcaba280b987cef10 Cr-Commit-Position: refs/heads/master@{#30140}

Patch Set 1 #

Total comments: 6

Patch Set 2 : Fix errors from review #

Patch Set 3 : Fix test bug #

Unified diffs Side-by-side diffs Delta from patch set Stats (+184 lines, -38 lines) Patch
M test/mjsunit/es6/block-conflicts.js View 4 chunks +16 lines, -4 lines 0 comments Download
M test/mjsunit/es6/block-let-declaration.js View 3 chunks +17 lines, -0 lines 0 comments Download
M test/mjsunit/es6/block-let-semantics.js View 3 chunks +15 lines, -12 lines 0 comments Download
M test/mjsunit/es6/block-scoping.js View 1 2 10 chunks +44 lines, -3 lines 0 comments Download
M test/mjsunit/harmony/block-conflicts-sloppy.js View 4 chunks +16 lines, -4 lines 0 comments Download
M test/mjsunit/harmony/block-let-declaration-sloppy.js View 3 chunks +17 lines, -0 lines 0 comments Download
M test/mjsunit/harmony/block-let-semantics-sloppy.js View 3 chunks +15 lines, -12 lines 0 comments Download
M test/mjsunit/harmony/block-scoping-sloppy.js View 1 2 10 chunks +44 lines, -3 lines 0 comments Download

Messages

Total messages: 19 (7 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1286923002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1286923002/1
5 years, 4 months ago (2015-08-12 01:47:20 UTC) #2
Dan Ehrenberg
5 years, 4 months ago (2015-08-12 01:51:08 UTC) #3
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 4 months ago (2015-08-12 02:13:31 UTC) #5
adamk
Glad to see these tests tightened up, this stuff was clearly under-tested before (since class ...
5 years, 4 months ago (2015-08-12 03:36:49 UTC) #6
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1286923002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1286923002/20001
5 years, 4 months ago (2015-08-12 17:47:21 UTC) #8
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1286923002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1286923002/40001
5 years, 4 months ago (2015-08-12 17:52:02 UTC) #11
Dan Ehrenberg
Fixed the issues, thanks. https://codereview.chromium.org/1286923002/diff/1/test/mjsunit/es6/block-scoping.js File test/mjsunit/es6/block-scoping.js (right): https://codereview.chromium.org/1286923002/diff/1/test/mjsunit/es6/block-scoping.js#newcode282 test/mjsunit/es6/block-scoping.js:282: //assertEquals(1,f.foo()); On 2015/08/12 at 03:36:49, ...
5 years, 4 months ago (2015-08-12 17:53:01 UTC) #12
adamk
lgtm
5 years, 4 months ago (2015-08-12 17:59:31 UTC) #13
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 4 months ago (2015-08-12 18:16:40 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1286923002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1286923002/40001
5 years, 4 months ago (2015-08-12 18:41:11 UTC) #17
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 4 months ago (2015-08-12 18:42:53 UTC) #18
commit-bot: I haz the power
5 years, 4 months ago (2015-08-12 18:43:11 UTC) #19
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/e261540b9ee3182451faac7fcaba280b987cef10
Cr-Commit-Position: refs/heads/master@{#30140}

Powered by Google App Engine
This is Rietveld 408576698