Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(16)

Issue 1286913002: add ConvertYUVAToARGBRow_MMX to media_perftests (Closed)

Created:
5 years, 4 months ago by fbarchard1
Modified:
5 years, 4 months ago
Reviewers:
fbarchard, DaleCurtis
CC:
chromium-reviews, feature-media-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add YUVConvertPerfTest.ConvertYUVAToARGBRow_MMX and YUVConvertPerfTest.I422ToARGBRow_SSSE3 to media_perftests. Fix math error when printing results by clearing the MMX state before doing float math. BUG=libyuv:473 Committed: https://crrev.com/98e918a3abdfcc2eaae3df9cc3dd9f8225f39edc Cr-Commit-Position: refs/heads/master@{#343140}

Patch Set 1 #

Patch Set 2 : add a libyuv performance test #

Patch Set 3 : full path for includes #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+50 lines, -3 lines) Patch
M media/base/yuv_convert_perftest.cc View 1 2 5 chunks +48 lines, -2 lines 3 comments Download
M media/media.gyp View 1 2 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 14 (2 generated)
fbarchard
Added benchmarks for yuva and libyuv [ RUN ] YUVConvertPerfTest.I422ToARGBRow_SSSE3 *RESULT yuv_convert_perftest: I422ToARGBRow_SSSE3= 8529.111991505004 runs/s ...
5 years, 4 months ago (2015-08-12 19:01:00 UTC) #2
brucedawson
-NaN runs/s seems dodgy. The other results should be printed with fewer than 16 digits ...
5 years, 4 months ago (2015-08-12 19:07:15 UTC) #3
DaleCurtis
Agree w/ Bruce, are the start and end times the same or something on those ...
5 years, 4 months ago (2015-08-12 21:03:12 UTC) #4
fbarchard1
full path for includes
5 years, 4 months ago (2015-08-12 23:20:58 UTC) #5
fbarchard
Done. [----------] 5 tests from YUVConvertPerfTest [ RUN ] YUVConvertPerfTest.I422ToARGBRow_SSSE3 *RESULT yuv_convert_perftest: I422ToARGBRow_SSSE3= 8699.585899711174 runs/s ...
5 years, 4 months ago (2015-08-12 23:27:05 UTC) #6
fbarchard
Tested using a Pentium4 emulator: bin32\drrun -t drcpusim -continue -cpu Prescott -fool_cpuid -- out\Release\media_perftests.exe --single-process-tests ...
5 years, 4 months ago (2015-08-13 00:43:18 UTC) #7
DaleCurtis
Thanks for fixing the MMX issue, lgtm https://codereview.chromium.org/1286913002/diff/40001/media/base/yuv_convert_perftest.cc File media/base/yuv_convert_perftest.cc (right): https://codereview.chromium.org/1286913002/diff/40001/media/base/yuv_convert_perftest.cc#newcode69 media/base/yuv_convert_perftest.cc:69: ASSERT_TRUE(base::CPU().has_ssse3()); On ...
5 years, 4 months ago (2015-08-13 00:46:40 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1286913002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1286913002/40001
5 years, 4 months ago (2015-08-13 01:05:12 UTC) #10
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 4 months ago (2015-08-13 01:17:16 UTC) #11
commit-bot: I haz the power
Patchset 3 (id:??) landed as https://crrev.com/98e918a3abdfcc2eaae3df9cc3dd9f8225f39edc Cr-Commit-Position: refs/heads/master@{#343140}
5 years, 4 months ago (2015-08-13 01:17:50 UTC) #12
Ken Rockot(use gerrit already)
A revert of this CL (patchset #3 id:40001) has been created in https://codereview.chromium.org/1288223003/ by rockot@chromium.org. ...
5 years, 4 months ago (2015-08-13 01:28:21 UTC) #13
DaleCurtis
5 years, 4 months ago (2015-08-13 16:24:45 UTC) #14
Message was sent while issue was closed.
Whoops, yeah you need to update the BUILD.gn file as well.

Powered by Google App Engine
This is Rietveld 408576698