Issue 128683004: Refactor IDBIndex::get/getKey

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 128683004: Refactor IDBIndex::get/getKey (Closed)

Created:
6 years, 11 months ago by rwlbuis

Modified:
6 years, 11 months ago

Reviewers:
alecflett, jsbell

CC:
blink-reviews, dgrogan, alecflett, jsbell, cmumford

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Visibility:
Public.

Refactor IDBIndex::get/getKey These methods have the same implementation except for one boolean flag, so add a helper method for this. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=164706

Created: 6 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+9 lines, -25 lines)			Patch
	M	Source/modules/indexeddb/IDBIndex.h	View		1 chunk	+2 lines, -0 lines	0 comments	Download
	M	Source/modules/indexeddb/IDBIndex.cpp	View		2 chunks	+7 lines, -25 lines	0 comments	Download

Total messages: 4 (0 generated)

rwlbuis

Simple refactoring resulting in smaller binary code size.

6 years, 11 months ago (2014-01-08 18:21:58 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rob.buis@samsung.com/128683004/1

6 years, 11 months ago (2014-01-08 18:37:25 UTC) #3

Message was sent while issue was closed.

Change committed as 164706