Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(63)

Unified Diff: ppapi/shared_impl/media_stream_frame.h

Issue 128683003: [PPAPI] Implement media stream video track API (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@video_track_impl_cl
Patch Set: Fix review issues Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ppapi/shared_impl/media_stream_frame.h
diff --git a/ppapi/shared_impl/media_stream_frame.h b/ppapi/shared_impl/media_stream_frame.h
new file mode 100644
index 0000000000000000000000000000000000000000..32490ec9cc95c5ee1ab2b25e66a414a2eaf470a3
--- /dev/null
+++ b/ppapi/shared_impl/media_stream_frame.h
@@ -0,0 +1,49 @@
+// Copyright (c) 2014 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef PPAPI_SHARED_IMPL_MEDIA_STREAM_FRAME_H_
+#define PPAPI_SHARED_IMPL_MEDIA_STREAM_FRAME_H_
+
+#include "ppapi/c/ppb_video_frame.h"
+
+namespace ppapi {
+
+union MediaStreamFrame {
+ enum Type {
+ TYPE_UNKNOWN = 0,
+ TYPE_AUDIO = 1,
+ TYPE_VIDEO = 2,
+ };
+
+ struct Header {
+ Type type;
+ uint32_t size;
+ };
+ PP_COMPILE_ASSERT_SIZE_IN_BYTES(Header, 8);
dmichael (off chromium) 2014/01/14 16:12:03 It would be helpful to readers to comment on why i
Peng 2014/01/14 21:31:35 Done.
+
+ struct Audio {
+ Header header;
+ // TODO(penghuang): implement the audio frame.
+ };
+ PP_COMPILE_ASSERT_SIZE_IN_BYTES(Audio, 8);
+
+ struct Video {
+ Header header;
+ PP_TimeDelta timestamp;
+ PP_VideoFrame_Format format;
+ PP_Size size;
+ uint32_t data_size;
+ // Uses 8 bytes to make sure below compile assert work in all platforms.
dmichael (off chromium) 2014/01/14 16:12:03 I would maybe rephrase to: "Uses 8 bytes to make s
Peng 2014/01/14 21:31:35 Done.
+ uint8_t data[8];
+ };
+ PP_COMPILE_ASSERT_SIZE_IN_BYTES(Video, 40);
+
+ Header header;
+ Video video;
+ Audio audio;
+};
+
+} // namespace ppapi
+
+#endif // PPAPI_SHARED_IMPL_MEDIA_STREAM_FRAME_H_

Powered by Google App Engine
This is Rietveld 408576698